[pull] master from monkeytypegame:master#726
Merged
pull[bot] merged 3 commits intoUncodedtech:masterfrom Dec 14, 2025
Merged
Conversation
) ### Description * `update()` could hit a race where settings became `null` between checks, causing a`TypeError` at runtime. * Async callbacks (setTimeout) accessed the global settings after it was cleared, leading to runaway errors. <img width="1887" height="755" alt="Screenshot 2025-12-12 135316" src="https://github.com/user-attachments/assets/ba6bd13c-c052-4870-ba7c-cfeae916b6dc" /> **fix** settings once (currentSettings) at the start of update() and use that for all property access and scheduling, so the loop never touches a null/stale reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )