Implement stacked bar regression test#660
Open
mvanhorn wants to merge 1 commit intoUltraplot:mainfrom
Open
Conversation
Replace the skipped test_bar_stack() placeholder with a real regression test that verifies both bar and area stacking behavior across a 2x2 subplot grid (stacked vs unstacked for each type). Fixes Ultraplot#642
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the skipped
test_bar_stack()placeholder with a working regression test. The test creates a 2x2 subplot grid covering unstacked bars, stacked bars, unstacked area, and stacked area.Why this matters
The skipped test was dead weight in the test suite. Stacking behavior is a core feature that should have regression coverage. This test catches regressions in both
bar()andarea()stacking logic.Changes
ultraplot/tests/test_1dplots.py: Removed@pytest.mark.skip("TODO"), addedrngfixture parameter, implemented test body with 4 subplot panels covering bar/area stacking variants.Testing
--mpl-generate-path- renders correctly with all 4 panels showing expected stacking behavior.Fixes #642
This contribution was developed with AI assistance (Claude Code).