Firngrod/refactor key actions#1512
Open
firngrod wants to merge 1 commit intoUltimateHackingKeyboard:masterfrom
Open
Firngrod/refactor key actions#1512firngrod wants to merge 1 commit intoUltimateHackingKeyboard:masterfrom
firngrod wants to merge 1 commit intoUltimateHackingKeyboard:masterfrom
Conversation
Contributor
Author
|
Oops, didn't go from master. Will rebase and all that. |
firngrod
force-pushed
the
firngrod/refactor_key_actions
branch
from
06d59ff to
08f6190
Compare
Contributor
Author
|
Still builds, now running this version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored
key_action_tto akey_definition_tand akey_action_tbecause it seemed like a reasonable thing to do before allocating a whole bunch of instances of a class with members which I had no intention of using. Also, what really put me over the edge was my intention to add anisChordedmember to the class I would otherwise have been using to represent chord actions, and that just seemed silly to me.I have made a number of judgement calls on whether to go with the larger or smaller class across the code, feel free to disagree with me on those. Also on naming.
I can build a release package, and I am running
rightv1on my board right now.