Enable logging buffer UI for uhk60.#2845
Open
kareltucek wants to merge 1 commit intoUltimateHackingKeyboard:masterfrom
Open
Enable logging buffer UI for uhk60.#2845kareltucek wants to merge 1 commit intoUltimateHackingKeyboard:masterfrom
kareltucek wants to merge 1 commit intoUltimateHackingKeyboard:masterfrom
Conversation
ert78gb
reviewed
Mar 14, 2026
Member
ert78gb
left a comment
ert78gb
left a comment
There was a problem hiding this comment.
The PR overall fine I have some generic questions
Comment on lines
+90
to
+92
| this.isZephyrLoggingAllowed = connectedDevice?.id === UHK_80_DEVICE.id | ||
| || connectedDevice?.id === UHK_60_DEVICE.id | ||
| || connectedDevice?.id === UHK_60_V2_DEVICE.id; |
Member
There was a problem hiding this comment.
If we don't add other condition like firmware version then why not just allow logging when device is connected?
Suggested change
| this.isZephyrLoggingAllowed = connectedDevice?.id === UHK_80_DEVICE.id | |
| || connectedDevice?.id === UHK_60_DEVICE.id | |
| || connectedDevice?.id === UHK_60_V2_DEVICE.id; | |
| this.isZephyrLoggingAllowed = !!connectedDevice; |
| (click)="onToggleZephyrLogging()" | ||
| > | ||
| Zephyr logging | ||
| Logging |
Member
There was a problem hiding this comment.
If we rename here the Zephyr logging then maybe worth to rename/remove the zephyr from the code blocks too. The ZephyrLogService covers the dongle and UHK80 Left Zephyr logging. Maybe worth to rename the Zephyr to Shell. What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uhk60 now allows logging into the same usb buffer as the one used by (formerly) zephyr logging.