Skip to content

refactor: move conversational utils from cli to eval module#1402

Merged
cristipufu merged 1 commit intomainfrom
refactor/move-conversational-utils-to-eval-module
Mar 3, 2026
Merged

refactor: move conversational utils from cli to eval module#1402
cristipufu merged 1 commit intomainfrom
refactor/move-conversational-utils-to-eval-module

Conversation

@cristipufu
Copy link
Member

@cristipufu cristipufu commented Mar 3, 2026

Description

We're planning on separating the uipath.eval module into another package, we shouldn't reference CLI modules in our eval runtime.

Summary

  • Moved UiPathLegacyEvalChatMessagesMapper and all legacy conversational eval models from uipath._cli._evals._conversational_utils to uipath.eval.models._conversational_utils
  • Removes the uipath.eval module's dependency on the uipath._cli namespace
  • Updated all imports in helpers.py, evaluation_set.py, and test file

Test plan

  • All 1545 existing tests pass (including 21 conversational utils tests)
  • Verify no other consumers import from the old path

🤖 Generated with Claude Code

Move LegacyEvalChatMessagesMapper and related models from
uipath._cli._evals._conversational_utils to
uipath.eval.models._conversational_utils so the eval module
has no dependency on the cli namespace.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions github-actions bot added test:uipath-langchain Triggers tests in the uipath-langchain-python repository test:uipath-llamaindex Triggers tests in the uipath-llamaindex-python repository labels Mar 3, 2026
@cristipufu cristipufu self-assigned this Mar 3, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors legacy conversational-eval utilities by relocating them from the CLI namespace into the uipath.eval models layer, removing uipath.eval’s dependency on uipath._cli and updating import sites accordingly.

Changes:

  • Added uipath.eval.models._conversational_utils containing legacy conversational eval Pydantic models and mapping helpers.
  • Updated uipath.eval code to import legacy conversational utilities from the new module.
  • Updated the conversational utils test to import from the new location.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
tests/cli/eval/test_conversational_utils.py Updates imports to reference the new eval module location.
src/uipath/eval/models/evaluation_set.py Switches legacy conversational model imports to the new local module.
src/uipath/eval/models/_conversational_utils.py New module defining legacy conversational schemas and message mappers.
src/uipath/eval/helpers.py Switches mapper import to the new eval models module.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cristipufu cristipufu merged commit 060117e into main Mar 3, 2026
96 of 98 checks passed
@cristipufu cristipufu deleted the refactor/move-conversational-utils-to-eval-module branch March 3, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:uipath-langchain Triggers tests in the uipath-langchain-python repository test:uipath-llamaindex Triggers tests in the uipath-llamaindex-python repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants