fix: replace ast.literal_eval with json.loads for eval CLI parsing [AE-1071]#1400
Open
fix: replace ast.literal_eval with json.loads for eval CLI parsing [AE-1071]#1400
Conversation
…ing [AE-1071] ast.literal_eval cannot parse JSON values like null, true, and false, causing eval --input-overrides to fail when the backend sends JSON with these values. Switching to json.loads ensures proper JSON parsing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ast.literal_evalwithjson.loadsin theLiteralOptionCLI option class used by--input-overridesand--eval-idsast.literal_evalcannot parse JSON values likenull,true,false— causing eval runs with file input overrides containing these values to crashRoot Cause
Part of the fix for AE-1071 — eval sets with file inputs crash because:
null/true/false)LiteralOptionusesast.literal_evalwhich only understands Python literals (None/True/False)Test plan
test_literal_option.pywith 13 test cases covering JSON null/true/false parsing🤖 Generated with Claude Code