Skip to content

feat(cryptography): add PGP support for encryption, decryption, signing, and verification #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adrianignat13 merged 15 commits into from
Mar 3, 2026
Merged

feat(cryptography): add PGP support for encryption, decryption, signing, and verification #514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
4aef345
feat(cryptography): add PGP support for encryption, decryption, signi…
adrianignat13 Feb 25, 2026
147a901
fix(tests): replace Path.GetTempFileName with Path.GetRandomFileName
adrianignat13 Feb 25, 2026
0fb08ae
fix: address SonarQube findings across Cryptography activities
adrianignat13 Feb 26, 2026
4908259
remove .claude files
adrianignat13 Feb 26, 2026
b029a71
reduce code duplication
adrianignat13 Feb 26, 2026
03a98df
fix sonar issues
adrianignat13 Feb 26, 2026
7a656cd
cleanup
adrianignat13 Feb 26, 2026
2b1d61d
fix(cryptography): address PR #514 code review findings
adrianignat13 Feb 26, 2026
696f770
refactor(cryptography): co-locate IsVisible and IsRequired for Key fi…
adrianignat13 Feb 26, 2026
3c6cabf
fix(cryptography): fail fast when PGP sign/verify inputs are missing
adrianignat13 Mar 2, 2026
aeca699
refactor(cryptography): return exception from TranslatePgpException
adrianignat13 Mar 2, 2026
3693318
fix(cryptography): address remaining PR #514 review comments
adrianignat13 Mar 3, 2026
ba2fe81
fix(cryptography): use localized display names in exception messages
adrianignat13 Mar 3, 2026
e3edf30
fix(cryptography): reduce PgpVerify complexity and use PgpCore as NuG…
adrianignat13 Mar 3, 2026
87ef9d8
fix(cryptography): add missing validation, centralize PgpCore version…
adrianignat13 Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .../UiPath.Cryptography.Activities.Packaging/UiPath.Cryptography.Activities.Packaging.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
<ItemGroup Condition=" '$(TargetFramework)' == '$(PortableFramework)' ">
<PackageReference Include="System.Security.Cryptography.Cng" />
<PackageReference Include="System.Formats.Asn1" />
<PackageReference Include="PgpCore" />
</ItemGroup>

<ItemGroup>
Expand Down
60 changes: 30 additions & 30 deletions Activities/Cryptography/UiPath.Cryptography.Activities.Tests/CryptographyTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,13 @@ public void KeyedHashAlgorithmsMatch(KeyedHashAlgorithms enumValue)
}

[Theory]
[InlineData(SymmetricAlgorithms.AES)]
[InlineData(SymmetricAlgorithms.AESGCM)]
[InlineData(SymmetricAlgorithms.DES)]
[InlineData(SymmetricAlgorithms.RC2)]
[InlineData(SymmetricAlgorithms.Rijndael)]
[InlineData(SymmetricAlgorithms.TripleDES)]
public void SymmetricAlgorithmsEncryptionMatches(SymmetricAlgorithms enumValue)
[InlineData(EncryptionAlgorithm.AES)]
[InlineData(EncryptionAlgorithm.AESGCM)]
[InlineData(EncryptionAlgorithm.DES)]
[InlineData(EncryptionAlgorithm.RC2)]
[InlineData(EncryptionAlgorithm.Rijndael)]
[InlineData(EncryptionAlgorithm.TripleDES)]
public void EncryptionAlgorithmEncryptionMatches(EncryptionAlgorithm enumValue)
{
string toProcess = "`~1234567890-=qwertyuiop[]\\ASDFGHJKL:\"ZXCVBNM<>?ăîșțâ";
string key = "{>@#F09\0";
Expand All @@ -74,13 +74,13 @@ public void SymmetricAlgorithmsEncryptionMatches(SymmetricAlgorithms enumValue)
}

[Theory]
[InlineData(SymmetricAlgorithms.AES)]
[InlineData(SymmetricAlgorithms.AESGCM)]
[InlineData(SymmetricAlgorithms.DES)]
[InlineData(SymmetricAlgorithms.RC2)]
[InlineData(SymmetricAlgorithms.Rijndael)]
[InlineData(SymmetricAlgorithms.TripleDES)]
public void SymmetricAlgorithmsDecryptionMatches(SymmetricAlgorithms enumValue)
[InlineData(EncryptionAlgorithm.AES)]
[InlineData(EncryptionAlgorithm.AESGCM)]
[InlineData(EncryptionAlgorithm.DES)]
[InlineData(EncryptionAlgorithm.RC2)]
[InlineData(EncryptionAlgorithm.Rijndael)]
[InlineData(EncryptionAlgorithm.TripleDES)]
public void EncryptionAlgorithmDecryptionMatches(EncryptionAlgorithm enumValue)
{
string toProcess = "`~1234567890-=qwertyuiop[]\\ASDFGHJKL:\"ZXCVBNM<>?ăîșțâ";
string key = "{>@#F09\0";
Expand Down Expand Up @@ -109,8 +109,8 @@ public void SymmetricAlgorithmsDecryptionMatches(SymmetricAlgorithms enumValue)
[InlineData("This is just a test", "97dbfca4-7a3c-4fa3-90f3-d17603bbc4b7")]
public void AesGcmEncryptionMatches(string plainText, string key)
{
var encrypted = CryptographyHelper.EncryptData(SymmetricAlgorithms.AESGCM, Encoding.UTF8.GetBytes(plainText), Encoding.UTF8.GetBytes(key));
var decrypted = CryptographyHelper.DecryptData(SymmetricAlgorithms.AESGCM, encrypted, Encoding.UTF8.GetBytes(key));
var encrypted = CryptographyHelper.EncryptData(EncryptionAlgorithm.AESGCM, Encoding.UTF8.GetBytes(plainText), Encoding.UTF8.GetBytes(key));
var decrypted = CryptographyHelper.DecryptData(EncryptionAlgorithm.AESGCM, encrypted, Encoding.UTF8.GetBytes(key));
Assert.Equal(Encoding.UTF8.GetString(decrypted), plainText);
}

Expand Down Expand Up @@ -147,13 +147,13 @@ public void KeyedHashAlgorithmsMatchWithSecureString(KeyedHashAlgorithms enumVal
}

[Theory]
[InlineData(SymmetricAlgorithms.AES)]
[InlineData(SymmetricAlgorithms.AESGCM)]
[InlineData(SymmetricAlgorithms.DES)]
[InlineData(SymmetricAlgorithms.RC2)]
[InlineData(SymmetricAlgorithms.Rijndael)]
[InlineData(SymmetricAlgorithms.TripleDES)]
public void SymmetricAlgorithmsEncryptionMatchesWithSecureString(SymmetricAlgorithms enumValue)
[InlineData(EncryptionAlgorithm.AES)]
[InlineData(EncryptionAlgorithm.AESGCM)]
[InlineData(EncryptionAlgorithm.DES)]
[InlineData(EncryptionAlgorithm.RC2)]
[InlineData(EncryptionAlgorithm.Rijndael)]
[InlineData(EncryptionAlgorithm.TripleDES)]
public void EncryptionAlgorithmEncryptionMatchesWithSecureString(EncryptionAlgorithm enumValue)
{
string toProcess = "`~1234567890-=qwertyuiop[]\\ASDFGHJKL:\"ZXCVBNM<>?ăîșțâ";
SecureString keySecureString = TestingHelper.StringToSecureString("{>@#F09\0");
Expand All @@ -178,13 +178,13 @@ public void SymmetricAlgorithmsEncryptionMatchesWithSecureString(SymmetricAlgori
}

[Theory]
[InlineData(SymmetricAlgorithms.AES)]
[InlineData(SymmetricAlgorithms.AESGCM)]
[InlineData(SymmetricAlgorithms.DES)]
[InlineData(SymmetricAlgorithms.RC2)]
[InlineData(SymmetricAlgorithms.Rijndael)]
[InlineData(SymmetricAlgorithms.TripleDES)]
public void SymmetricAlgorithmsDecryptionMatchesWithSecureString(SymmetricAlgorithms enumValue)
[InlineData(EncryptionAlgorithm.AES)]
[InlineData(EncryptionAlgorithm.AESGCM)]
[InlineData(EncryptionAlgorithm.DES)]
[InlineData(EncryptionAlgorithm.RC2)]
[InlineData(EncryptionAlgorithm.Rijndael)]
[InlineData(EncryptionAlgorithm.TripleDES)]
public void EncryptionAlgorithmDecryptionMatchesWithSecureString(EncryptionAlgorithm enumValue)
{
string toProcess = "`~1234567890-=qwertyuiop[]\\ASDFGHJKL:\"ZXCVBNM<>?ăîșțâ";
SecureString keySecureString = TestingHelper.StringToSecureString("{>@#F09\0");
Expand Down
4 changes: 2 additions & 2 deletions Activities/Cryptography/UiPath.Cryptography.Activities.Tests/EncryptFileTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public void EncryptDecryptFile_HappyPath_Works(bool withOutputOverwrite)
{
InputFilePath = new InArgument<string>(tempInputFile),
Key = new InArgument<string>("key"),
Algorithm = SymmetricAlgorithms.AESGCM,
Algorithm = EncryptionAlgorithm.AESGCM,
OutputFilePath = new InArgument<string>(tempOutputFile),
KeyInputModeSwitch = KeyInputMode.Key,
Overwrite = withOutputOverwrite
Expand All @@ -45,7 +45,7 @@ public void EncryptDecryptFile_HappyPath_Works(bool withOutputOverwrite)
{
InputFilePath = new InArgument<string>(tempOutputFile),
Key = new InArgument<string>("key"),
Algorithm = SymmetricAlgorithms.AESGCM,
Algorithm = EncryptionAlgorithm.AESGCM,
OutputFilePath = new InArgument<string>(tempOutputFile2),
KeyInputModeSwitch = KeyInputMode.Key,
Overwrite = withOutputOverwrite
Expand Down
Loading