Open
Conversation
v-patel
requested changes
Mar 26, 2026
app/pages/admin/index.vue
Outdated
| monday.setDate(today.getDate() - dayOffset) | ||
| const mondayStr = monday.toISOString().split('T')[0] | ||
|
|
||
| const getCalculatedDate = (weekStartStr: string, dayName: string): string => { |
Contributor
There was a problem hiding this comment.
is this file still relevant? A lot of the logic here is duplicated elsewhere in the project.
Ex. getCalculatedDate is in the useAdmin composable...
Collaborator
Author
There was a problem hiding this comment.
not yet.. im working on optimizing it!
v-patel
reviewed
Mar 26, 2026
Comment on lines
+40
to
+42
| { id: Date.now(), type: 'video', text: '', textEs: '', reference: '', referenceEs: '', url: '' }, | ||
| { id: Date.now() + 1, type: 'text', text: '', textEs: '', reference: '', referenceEs: '', url: '' }, | ||
| { id: Date.now() + 2, type: 'mcq', text: '', textEs: '', reference: '', referenceEs: '', url: '', |
Contributor
There was a problem hiding this comment.
Placeholder right? ids shouldn't be generated like this.
Collaborator
Author
There was a problem hiding this comment.
These are the default questions that are always going to be there when they open up the builder tab. should i use the uuid library instead to generate the ids? or should i just make an increment everytime it is called?
Collaborator
Author
There was a problem hiding this comment.
should we just use addQuestion function here instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.