Conversation
CI Build PlanChanged FilesPython source (1 file)
Tests (1 file)
Documentation (2 files)
Build Configuration
Rationale
Updated by CI on each push. See path-filters.yml for category definitions. |
Preview Deployed
Note This preview is ephemeral. It will be lost when:
To restore, push any commit to this PR. |
Author
|
Hi @sunt05 - it would be great if you could have a look at this improvement and give your feedback/review :) many thanks! |
- CHANGELOG: [feat] -> [feature] per project conventions - Docstring: replace en-dash with ASCII hyphen in citation - Test docstring: fix reference typo (Apoud -> Grimmond & Oke) - Test: add missing sfr to stebbs_height test data - Remove unreachable dead code block (bldgh guaranteed non-None) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
sunt05
approved these changes
Apr 11, 2026
sunt05
left a comment
There was a problem hiding this comment.
Thanks for this, @dayantur — nice work grounding the forcing height validation in the Grimmond & Oke (1999) plan area fraction regimes. The sfr-dependent thresholds and the new upper bound check are a solid improvement.
I've pushed a small follow-up commit (d7d7f4b) fixing a few minor items:
- CHANGELOG tag
[feat]→[feature] - ASCII hyphen in the citation (en-dash →
-) - Reference typo in test docstring ("Apoud" → "Grimmond & Oke")
- Added missing
sfrto thestebbs_heighttest so it actually exercises that code path - Removed an unreachable dead code block (
if not candidates:afterbldghis guaranteed non-None)
All 7 forcing height tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves validate_forcing_height_vs_buildings by providing ranges for forcing height based on buildings plan area fraction (bldgs.sfr).
As before, two reference heights are used (this logic remains the same as before):
Main changes
References
For forcing height ranges reference, see Grimmond, C. S. B., and T. R. Oke, 1999: Aerodynamic
Properties of Urban Areas Derived from Analysis of Surface Form. J. Appl. Meteor.
Climatol., 38, 1262–1292, Fig. 1.