Add explicit InternalMassArea input to STEBBS#1282
Conversation
CI Build PlanChanged FilesFortran source (3 files)
Rust bridge (2 files)
Python source (4 files)
Tests (9 files)
Documentation (5 files)
Build Configuration
Rationale
Updated by CI on each push. See path-filters.yml for category definitions. |
Preview Deployed
Note This preview is ephemeral. It will be lost when:
To restore, push any commit to this PR. |
|
Hi @sunt05 , This PR include two minor updates for the STEBBS, could you please take a look if this make sense to you? many thanks. |
sunt05
left a comment
There was a problem hiding this comment.
Two minor issues to sort before merging.
-
.codex— empty file committed. This looks like a Codex CLI config artifact (0-byte file). Should be removed from the PR — it's not in.gitignoreand doesn't belong in the repo. -
InternalMassAreadefault mismatch.site.pysetsdefault=100butschema.jsonhas"default": 20. All YAML fixtures use100. Which value is intended? Please set the correct default insite.pyand regenerateschema.jsonvia the publisher script rather than editing it by hand.
Everything else looks good — QBAE sign fix is correct, bridge FFI is properly versioned, and test coverage is adequate.
| "type": "null" | ||
| } | ||
| ], | ||
| "default": 20, |
There was a problem hiding this comment.
"default": 20 here but site.py has default=100 and all fixtures use 100. Which is the intended default? If 100 is correct, regenerate this file from the Pydantic model rather than editing by hand.
Resolve CHANGELOG.md conflict: keep both 8 Apr and 9 Apr entries. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…SUEWS into YL/STEBBS/internalmass
|
Thanks @sunt05 for your suggestion! I have revised them accordingly |
sunt05
left a comment
There was a problem hiding this comment.
Thanks for the quick fixes @yiqing1021 — both issues sorted. Approving.
1) Summary
This PR replaces the STEBBS internal mass cube assumption with an explicit user-defined parameter,
InternalMassArea.2) Main Changes
Previously, STEBBS estimated the internal mass heat exchange area from the internal mass volume by assuming a cubic geometry, which underestimates the convective heat exchange between internal mass and indoor air.This PR removes that assumption from the core building setup and instead reads
InternalMassAreadirectly from the building archetype input.In addition, this PR fixes a bug related to the sign convention of
Q_BAE(heat emission through air exchange), which was previously incorrect.3) Notes
InternalMassAreais now explicitly defined and used for indoor mass heat exchange calculations.RatioInternalVolumeis retained and continues to control internal mass volume and associated thermal storage.