Skip to content

Resolve minor linter findings #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RandomByte merged 2 commits into from
May 22, 2026
+2 −2
Merged

Resolve minor linter findings #1395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
685d6c1
refactor(server): Fix dead branch in addCustomMiddleware
RandomByte May 22, 2026
3d4ddaf
refactor(builder): Add message to SapUiDefineCall TypeError
RandomByte May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/builder/lib/lbt/calls/SapUiDefine.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class SapUiDefineCall {
this.dependencies = this.dependencyArray.elements.map( (elem) => {
const value = getStringValue(elem);
if ( !value ) {
throw new TypeError();
throw new TypeError(`dependency element is not a string literal in module ${this.name}`);
}
return resolveRelativeRequireJSName(this.name, value);
});
Expand Down
2 changes: 1 addition & 1 deletion packages/server/lib/middleware/MiddlewareManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ class MiddlewareManager {
async addCustomMiddleware() {
const project = this.graph.getRoot();
const projectCustomMiddleware = project.getCustomMiddleware();
if (!projectCustomMiddleware.length === 0) {
if (projectCustomMiddleware.length === 0) {
return; // No custom middleware defined
}

Expand Down
Loading