Skip to content

Add d-morrison/macros as git submodule with demo usage#35

Draft
Copilot wants to merge 5 commits intomainfrom
copilot/add-macros-repo-submodule
Draft

Add d-morrison/macros as git submodule with demo usage#35
Copilot wants to merge 5 commits intomainfrom
copilot/add-macros-repo-submodule

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 10, 2026 •
edited
Loading

  • Explore repository structure and understand macros repo
  • Add d-morrison/macros as a git submodule at macros/
  • Update _quarto.yml to include macros/macros.qmd for HTML and macros-pdf.tex for PDF
  • Demo custom macros in chapter2.qmd
  • Fix CI failure: add submodules: true to actions/checkout@v4 in publish.yml and preview.yml
  • Fix LaTeX PDF error: create macros-pdf.tex (macros without HTML comments) and use it for PDF include-in-header
  • Add !macros-pdf.tex exception to .gitignore so the file is tracked

Copilot AI linked an issue Apr 10, 2026 that may be closed by this pull request
include macros repo as submodule #34
Open
Copilot AI changed the title [WIP] Include macros repo as submodule Add d-morrison/macros as git submodule with demo usage Apr 10, 2026
Copilot AI requested a review from d-morrison April 10, 2026 22:52
@d-morrison
Copy link
Copy Markdown
Member

d-morrison commented Apr 10, 2026

@copilot fix https://github.com/UCD-SERG/qbt/actions/runs/24267771989/job/70870224371?pr=35

@d-morrison
Fix CI: add submodules: true to checkout steps in publish and preview…
c7a57af 
… workflows

Agent-Logs-Url: https://github.com/UCD-SERG/qbt/sessions/ee911950-8e53-42f9-b24b-c941f5f8bf2b

Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 10, 2026

@copilot fix https://github.com/UCD-SERG/qbt/actions/runs/24267771989/job/70870224371?pr=35

The CI was failing because the actions/checkout steps in publish.yml and preview.yml weren't initializing the git submodule. Fixed in c7a57af by adding submodules: true to both checkout steps.

@d-morrison
Copy link
Copy Markdown
Member

d-morrison commented Apr 11, 2026

@copilot fix https://github.com/UCD-SERG/qbt/actions/runs/24269192368/job/70870746717?pr=35

Copilot AI and others added 2 commits April 11, 2026 00:21
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 11, 2026

@copilot fix https://github.com/UCD-SERG/qbt/actions/runs/24269192368/job/70870746717?pr=35

The PDF build was failing because macros/macros.qmd contains HTML comments (<!-- -->), which are invalid in a LaTeX preamble. Fixed in 9c44df4 by:

  • Creating macros-pdf.tex — a copy of macros/macros.qmd with HTML comments stripped
  • Updating _quarto.yml to use macros/macros.qmd for HTML and macros-pdf.tex for PDF
  • Adding !macros-pdf.tex to .gitignore so it's tracked despite the *.tex exclusion rule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d-morrison d-morrison Awaiting requested review from d-morrison

Assignees

@d-morrison d-morrison

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

include macros repo as submodule

2 participants

@d-morrison