Conversation
…ng into a helper. Minor attachement fixes as well
adding table to html when pdf derivative is parsed
…t corrupt same data files
…ng with line endings in sample data
…derivative path bug
…d so we can use base libpff
baibhavr
reviewed
Apr 28, 2022
Collaborator
baibhavr
left a comment
baibhavr
left a comment
There was a problem hiding this comment.
Other than the comment mentioned, I did not come across other issues.
| # Install Python dependancies | ||
| RUN pip install -r requirements.txt | ||
| # Install Optional Python dependancies | ||
| RUN pip install libpff-python-ratom==20200808 |
Collaborator
There was a problem hiding this comment.
Are we still keeping the ratom libpff? I saw ratom in pipfiles too.
I didn't come across other issues.
11 tasks
Collaborator
Author
|
Closing as #150 addresses this and more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Contribution
What does this implement/fix? Explain your changes.
Previously we could only read attachment filenames with the
get_filenames()method which has yet to be merged into libpff.Now this reads filenames from hex entries which works with libpff.
Link to issue?
n/a
Pull Request Checklist
Please check if your PR fulfills the following requirements:
How has this been tested?
Operating System: win10
Python Version: 3.7.3
Licensing