Add folding range lsp support#69
Open
ssmifi wants to merge 1 commit into
Open
Conversation
msujew
reviewed
May 13, 2026
Member
msujew
left a comment
msujew
left a comment
There was a problem hiding this comment.
Thanks, I like the filter strategy approach! A few suggestion, see below 👍
| IncludeLastFoldingLineForComment() bool | ||
| } | ||
|
|
||
| type DefaultFoldingRangeFilter struct{} |
Member
There was a problem hiding this comment.
Minor: Add a comment what the default implementation does.
Comment on lines
+132
to
+135
| foldRange = core.TextRange{ | ||
| Start: segment.Range.Start, | ||
| End: core.TextLocation{Line: segment.Range.End.Line - 1, Column: segment.Range.End.Column}, | ||
| } |
Member
There was a problem hiding this comment.
Suggestion: I don't think the logic is correct here. It should use the Column value at the end of the line.
| } | ||
| } | ||
| t.Errorf("Should have folding range for marker '%s' (lines %d-%d)", label, markerRange.Start.Line, markerRange.End.Line) | ||
| } |
Member
There was a problem hiding this comment.
Suggestion: I would like to see a AssertFoldingRanges in the Doc struct instead of extracting the markers directly. See my other PR for inspiration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #26
and implements the folding feature, which is basically a port from Langium.
Customization can be done via the
FoldingRangeFilterinterface.