feat: additional heading top padding (BLO-1008)#2690
Merged
nperez0111 merged 1 commit intomainfrom May 1, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughThe changes adjust heading block spacing to follow typographic conventions by adding top padding to heading blocks and increasing side menu row heights for heading elements at different levels. Test cases are updated to accommodate the new layout changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/react/src/editor/styles.css`:
- Around line 245-255: The side-menu misses height overrides for heading levels
4–6 so those rows remain vertically offset; add selectors matching the existing
pattern (.bn-side-menu[data-block-type="heading"][data-level="4"],
..."[data-level="5"]", "[data-level="6"]) and set explicit height values for
each to re-center the side-menu rows (compute heights the same way you did for
levels 1–3 so they account for the extra top spacing applied in Block.css,
matching the centering logic used in
.bn-side-menu[data-block-type="heading"][data-level="1"/"2"/"3"]).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 9fd2f6a2-0ebe-4005-91c9-ea6d08769c71
⛔ Files ignored due to path filters (30)
tests/src/end-to-end/colors/colors.test.ts-snapshots/backgroundColorMark-chromium-linux.pngis excluded by!**/*.pngtests/src/end-to-end/colors/colors.test.ts-snapshots/backgroundColorMark-firefox-linux.pngis excluded by!**/*.pngtests/src/end-to-end/colors/colors.test.ts-snapshots/backgroundColorMark-webkit-linux.pngis excluded by!**/*.pngtests/src/end-to-end/colors/colors.test.ts-snapshots/blockBackgroundColor-chromium-linux.pngis excluded by!**/*.pngtests/src/end-to-end/colors/colors.test.ts-snapshots/blockBackgroundColor-firefox-linux.pngis excluded by!**/*.pngtests/src/end-to-end/colors/colors.test.ts-snapshots/blockBackgroundColor-webkit-linux.pngis excluded by!**/*.pngtests/src/end-to-end/colors/colors.test.ts-snapshots/blockTextColor-chromium-linux.pngis excluded by!**/*.pngtests/src/end-to-end/colors/colors.test.ts-snapshots/blockTextColor-firefox-linux.pngis excluded by!**/*.pngtests/src/end-to-end/colors/colors.test.ts-snapshots/blockTextColor-webkit-linux.pngis excluded by!**/*.pngtests/src/end-to-end/colors/colors.test.ts-snapshots/textColorMark-chromium-linux.pngis excluded by!**/*.pngtests/src/end-to-end/colors/colors.test.ts-snapshots/textColorMark-firefox-linux.pngis excluded by!**/*.pngtests/src/end-to-end/colors/colors.test.ts-snapshots/textColorMark-webkit-linux.pngis excluded by!**/*.pngtests/src/end-to-end/draghandle/draghandle.test.ts-snapshots/draghandlemenu-chromium-linux.pngis excluded by!**/*.pngtests/src/end-to-end/draghandle/draghandle.test.ts-snapshots/draghandlemenu-firefox-linux.pngis excluded by!**/*.pngtests/src/end-to-end/draghandle/draghandle.test.ts-snapshots/draghandlemenu-webkit-linux.pngis excluded by!**/*.pngtests/src/end-to-end/slashmenu/slashmenu.test.ts-snapshots/slash-menu-end-product-chromium-linux.pngis excluded by!**/*.pngtests/src/end-to-end/slashmenu/slashmenu.test.ts-snapshots/slash-menu-end-product-firefox-linux.pngis excluded by!**/*.pngtests/src/end-to-end/slashmenu/slashmenu.test.ts-snapshots/slash-menu-end-product-webkit-linux.pngis excluded by!**/*.pngtests/src/end-to-end/static/static.test.ts-snapshots/static-rendering-chromium-linux.pngis excluded by!**/*.pngtests/src/end-to-end/static/static.test.ts-snapshots/static-rendering-equality-chromium-linux.pngis excluded by!**/*.pngtests/src/end-to-end/static/static.test.ts-snapshots/static-rendering-equality-firefox-linux.pngis excluded by!**/*.pngtests/src/end-to-end/static/static.test.ts-snapshots/static-rendering-equality-webkit-linux.pngis excluded by!**/*.pngtests/src/end-to-end/static/static.test.ts-snapshots/static-rendering-firefox-linux.pngis excluded by!**/*.pngtests/src/end-to-end/static/static.test.ts-snapshots/static-rendering-webkit-linux.pngis excluded by!**/*.pngtests/src/end-to-end/textalignment/textAlignment.test.ts-snapshots/alignTextMultipleBlocks-chromium-linux.pngis excluded by!**/*.pngtests/src/end-to-end/textalignment/textAlignment.test.ts-snapshots/alignTextMultipleBlocks-firefox-linux.pngis excluded by!**/*.pngtests/src/end-to-end/textalignment/textAlignment.test.ts-snapshots/alignTextMultipleBlocks-webkit-linux.pngis excluded by!**/*.pngtests/src/end-to-end/textalignment/textAlignment.test.ts-snapshots/alignTextSingleBlock-chromium-linux.pngis excluded by!**/*.pngtests/src/end-to-end/textalignment/textAlignment.test.ts-snapshots/alignTextSingleBlock-firefox-linux.pngis excluded by!**/*.pngtests/src/end-to-end/textalignment/textAlignment.test.ts-snapshots/alignTextSingleBlock-webkit-linux.pngis excluded by!**/*.png
📒 Files selected for processing (3)
packages/core/src/editor/Block.csspackages/react/src/editor/styles.csstests/src/end-to-end/multicolumn/multicolumn.test.ts
Comment on lines
245
to
255
| .bn-side-menu[data-block-type="heading"][data-level="1"] { | ||
| height: 78px; | ||
| height: 108px; | ||
| } | ||
|
|
||
| .bn-side-menu[data-block-type="heading"][data-level="2"] { | ||
| height: 54px; | ||
| height: 84px; | ||
| } | ||
|
|
||
| .bn-side-menu[data-block-type="heading"][data-level="3"] { | ||
| height: 37px; | ||
| height: 67px; | ||
| } |
There was a problem hiding this comment.
Add side-menu height overrides for heading levels 4–6.
packages/core/src/editor/Block.css Line 130 applies extra top spacing to all headings, but this file only re-centers side-menu rows for levels 1–3. Levels 4–6 still use the 30px fallback and will be vertically off.
💡 Proposed CSS extension
.bn-side-menu[data-block-type="heading"][data-level="3"] {
height: 67px;
}
+
+.bn-side-menu[data-block-type="heading"][data-level="4"] {
+ height: 60px;
+}
+
+.bn-side-menu[data-block-type="heading"][data-level="5"] {
+ height: 58px;
+}
+
+.bn-side-menu[data-block-type="heading"][data-level="6"] {
+ height: 55px;
+}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/react/src/editor/styles.css` around lines 245 - 255, The side-menu
misses height overrides for heading levels 4–6 so those rows remain vertically
offset; add selectors matching the existing pattern
(.bn-side-menu[data-block-type="heading"][data-level="4"],
..."[data-level="5"]", "[data-level="6"]) and set explicit height values for
each to re-center the side-menu rows (compute heights the same way you did for
levels 1–3 so they account for the extra top spacing applied in Block.css,
matching the centering logic used in
.bn-side-menu[data-block-type="heading"][data-level="1"/"2"/"3"]).
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
nperez0111
approved these changes
Apr 29, 2026
Contributor
nperez0111
left a comment
nperez0111
left a comment
There was a problem hiding this comment.
I've been meaning to do this for a long time
nperez0111
changed the title
Collaborator
|
@matthewlipski While this addresses the issue, we could explore some nest steps. For example:
you can research some typography patterns like: (this was a quick search, there are probably some design blogs written about this as well) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds extra padding to the tops of heading blocks, as this makes it more clear that the heading relates to the content below it, not above it.
Closes #2414
Rationale
See above.
Changes
Impact
N/A
Testing
Updated e2e screenshots.
Screenshots/Video
N/A
Checklist
Additional Notes
N/A
Summary by CodeRabbit
Style
Tests