Skip to content

feat: Drag hendle menu delete button removes all other blocks in selection (BLO-1007) #2683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthewlipski merged 3 commits into from
Apr 28, 2026
Merged

feat: Drag hendle menu delete button removes all other blocks in selection (BLO-1007) #2683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d4049be
Made side menu delete button delete other blocks spanned by selection
matthewlipski Apr 28, 2026
030a50d
Added e2e tests
matthewlipski Apr 28, 2026
31718b8
Reverted `package.json`
matthewlipski Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/react/src/components/SideMenu/DragHandleMenu/DefaultItems/RemoveBlockItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,14 @@ export const RemoveBlockItem = (props: { children: ReactNode }) => {
return (
<Components.Generic.Menu.Item
className={"bn-menu-item"}
onClick={() => editor.removeBlocks([block])}
onClick={() => {
const selectedBlocks = editor.getSelection()?.blocks;
const blocksToRemove =
selectedBlocks && selectedBlocks.some((b) => b.id === block.id)
? selectedBlocks
: [block];
editor.removeBlocks(blocksToRemove);
}}
>
{props.children}
</Components.Generic.Menu.Item>
Expand Down
59 changes: 59 additions & 0 deletions tests/src/end-to-end/draghandle/draghandle.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { expect, Page } from "@playwright/test";
import { test } from "../../setup/setupScript.js";
import {
BASE_URL,
BULLET_LIST_SELECTOR,
DRAG_HANDLE_ADD_SELECTOR,
DRAG_HANDLE_MENU_SELECTOR,
DRAG_HANDLE_SELECTOR,
Expand Down Expand Up @@ -158,6 +159,64 @@ test.describe("Check Draghandle functionality", () => {
await compareDocToSnapshot(page, "dragHandleDocStructure");
});

test("Delete button should delete all blocks in multi-block selection when hovered block is in selection", async () => {
await executeSlashCommand(page, "h1");
await page.keyboard.type("Heading 1");
await page.keyboard.press("Enter", { delay: 10 });
await executeSlashCommand(page, "h2");
await page.keyboard.type("Heading 2");
await page.keyboard.press("Enter", { delay: 10 });
await executeSlashCommand(page, "h3");
await page.keyboard.type("Heading 3");
await page.keyboard.press("Enter", { delay: 10 });
await executeSlashCommand(page, "bullet");
await page.keyboard.type("Bullet List");

await page.keyboard.down("Shift");
await page.keyboard.press("ArrowUp");
await page.keyboard.press("ControlOrMeta+ArrowLeft");
await page.keyboard.up("Shift");

await page.hover(H_THREE_BLOCK_SELECTOR);
await page.click(DRAG_HANDLE_SELECTOR);
await page.click("text=Delete");
await page.waitForSelector(H_ONE_BLOCK_SELECTOR);
await page.waitForSelector(H_TWO_BLOCK_SELECTOR);
await page.waitForSelector(H_THREE_BLOCK_SELECTOR, { state: "detached" });
await page.waitForSelector(BULLET_LIST_SELECTOR, { state: "detached" });

await compareDocToSnapshot(page, "draghandledeletemultiselection");
});

test("Delete button should delete only hovered block when it is outside multi-block selection", async () => {
await executeSlashCommand(page, "h1");
await page.keyboard.type("Heading 1");
await page.keyboard.press("Enter", { delay: 10 });
await executeSlashCommand(page, "h2");
await page.keyboard.type("Heading 2");
await page.keyboard.press("Enter", { delay: 10 });
await executeSlashCommand(page, "h3");
await page.keyboard.type("Heading 3");
await page.keyboard.press("Enter", { delay: 10 });
await executeSlashCommand(page, "bullet");
await page.keyboard.type("Bullet List");

await page.keyboard.down("Shift");
await page.keyboard.press("ArrowUp");
await page.keyboard.press("ControlOrMeta+ArrowLeft");
await page.keyboard.up("Shift");

await page.hover(H_ONE_BLOCK_SELECTOR);
await page.click(DRAG_HANDLE_SELECTOR);
await page.click("text=Delete");
await page.waitForSelector(H_ONE_BLOCK_SELECTOR, { state: "detached" });
await page.waitForSelector(H_TWO_BLOCK_SELECTOR);
await page.waitForSelector(H_THREE_BLOCK_SELECTOR);
await page.waitForSelector(BULLET_LIST_SELECTOR);

await compareDocToSnapshot(page, "draghandledeletehoveroutsideselection");
});

test("Deleting block with children should delete all children", async () => {
await page.goto(BASE_URL, { waitUntil: "networkidle" });
await focusOnEditor(page);
Expand Down
96 changes: 96 additions & 0 deletions ...le/draghandle.test.ts-snapshots/draghandledeletehoveroutsideselection-chromium-linux.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
{
"type": "doc",
"content": [
{
"type": "blockGroup",
"content": [
{
"type": "blockContainer",
"attrs": {
"id": "2"
},
"content": [
{
"type": "heading",
"attrs": {
"backgroundColor": "default",
"textColor": "default",
"textAlignment": "left",
"level": 2,
"isToggleable": false
},
"content": [
{
"type": "text",
"text": "Heading 2"
}
]
}
]
},
{
"type": "blockContainer",
"attrs": {
"id": "3"
},
"content": [
{
"type": "heading",
"attrs": {
"backgroundColor": "default",
"textColor": "default",
"textAlignment": "left",
"level": 3,
"isToggleable": false
},
"content": [
{
"type": "text",
"text": "Heading 3"
}
]
}
]
},
{
"type": "blockContainer",
"attrs": {
"id": "4"
},
"content": [
{
"type": "bulletListItem",
"attrs": {
"backgroundColor": "default",
"textColor": "default",
"textAlignment": "left"
},
"content": [
{
"type": "text",
"text": "Bullet List"
}
]
}
]
},
{
"type": "blockContainer",
"attrs": {
"id": "1"
},
"content": [
{
"type": "paragraph",
"attrs": {
"backgroundColor": "default",
"textColor": "default",
"textAlignment": "left"
}
}
]
}
]
}
]
}
96 changes: 96 additions & 0 deletions ...dle/draghandle.test.ts-snapshots/draghandledeletehoveroutsideselection-firefox-linux.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
{
"type": "doc",
"content": [
{
"type": "blockGroup",
"content": [
{
"type": "blockContainer",
"attrs": {
"id": "2"
},
"content": [
{
"type": "heading",
"attrs": {
"backgroundColor": "default",
"textColor": "default",
"textAlignment": "left",
"level": 2,
"isToggleable": false
},
"content": [
{
"type": "text",
"text": "Heading 2"
}
]
}
]
},
{
"type": "blockContainer",
"attrs": {
"id": "3"
},
"content": [
{
"type": "heading",
"attrs": {
"backgroundColor": "default",
"textColor": "default",
"textAlignment": "left",
"level": 3,
"isToggleable": false
},
"content": [
{
"type": "text",
"text": "Heading 3"
}
]
}
]
},
{
"type": "blockContainer",
"attrs": {
"id": "4"
},
"content": [
{
"type": "bulletListItem",
"attrs": {
"backgroundColor": "default",
"textColor": "default",
"textAlignment": "left"
},
"content": [
{
"type": "text",
"text": "Bullet List"
}
]
}
]
},
{
"type": "blockContainer",
"attrs": {
"id": "1"
},
"content": [
{
"type": "paragraph",
"attrs": {
"backgroundColor": "default",
"textColor": "default",
"textAlignment": "left"
}
}
]
}
]
}
]
}
96 changes: 96 additions & 0 deletions ...ndle/draghandle.test.ts-snapshots/draghandledeletehoveroutsideselection-webkit-linux.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
{
"type": "doc",
"content": [
{
"type": "blockGroup",
"content": [
{
"type": "blockContainer",
"attrs": {
"id": "2"
},
"content": [
{
"type": "heading",
"attrs": {
"backgroundColor": "default",
"textColor": "default",
"textAlignment": "left",
"level": 2,
"isToggleable": false
},
"content": [
{
"type": "text",
"text": "Heading 2"
}
]
}
]
},
{
"type": "blockContainer",
"attrs": {
"id": "3"
},
"content": [
{
"type": "heading",
"attrs": {
"backgroundColor": "default",
"textColor": "default",
"textAlignment": "left",
"level": 3,
"isToggleable": false
},
"content": [
{
"type": "text",
"text": "Heading 3"
}
]
}
]
},
{
"type": "blockContainer",
"attrs": {
"id": "4"
},
"content": [
{
"type": "bulletListItem",
"attrs": {
"backgroundColor": "default",
"textColor": "default",
"textAlignment": "left"
},
"content": [
{
"type": "text",
"text": "Bullet List"
}
]
}
]
},
{
"type": "blockContainer",
"attrs": {
"id": "1"
},
"content": [
{
"type": "paragraph",
"attrs": {
"backgroundColor": "default",
"textColor": "default",
"textAlignment": "left"
}
}
]
}
]
}
]
}
Loading
Loading