Update to tor 0.4.9.5 on Android, Add script for future android tor builds #3121
Draft
Update to tor 0.4.9.5 on Android, Add script for future android tor builds #3121
Conversation
mcginty
reviewed
Mar 5, 2026
| /e2e/artifacts | ||
| /e2e/visual-regressions/local | ||
|
|
||
| quiet_libtor_android |
Collaborator
There was a problem hiding this comment.
Would it make sense to put this folder within packages/mobile/android/build which is already an ignored Android artifact directory?
Collaborator
Author
|
This actually isnt ready for review yet but no it wouldn't make sense to put this there.
That directory would be wiped and rewiped through rebuilding the android app in gradle / android studio - which would be very unwelcomed when you're troubleshooting a new tor build.
I can find a diff spot for it, but most people wouldn't even have this on their machine its just an artifact for those who decide to locally build a new tor arm64 bin for android.
…On Thursday, March 5th, 2026 at 5:58 AM, Jake McGinty ***@***.***> wrote:
@mcginty commented on this pull request.
---------------------------------------------------------------
In [packages/mobile/.gitignore](#3121 (comment)):
> @@ -83,3 +83,5 @@ buck-out/
# Detox
/e2e/artifacts
/e2e/visual-regressions/local
+
+quiet_libtor_android
Would it make sense to put this folder within packages/mobile/android/build which is already an ignored Android artifact directory?
---------------------------------------------------------------
In [packages/mobile/update-android-libtor.sh](#3121 (comment)):
> @@ -0,0 +1,43 @@
+#!/bin/bash
+
⬇️ Suggested change
-
+set -e
+cd "$(dirname "$0")"
---------------------------------------------------------------
In [packages/mobile/update-android-libtor.sh](#3121 (comment)):
> + echo "Building libtor.so..."
+ else
+ echo "You can update the submodules to point to newer versions of tor, openssl, etc. Commit them and rerun this script."
+ exit
+fi
+
+
+# set to only build arm64-v8a matching quiet...
+./tor-droid-make.sh build
+
+ls -al external/lib/arm64-v8a
+cp -fv external/lib/arm64-v8a/libtor.so ../android/app/src/main/jniLibs/arm64-v8a/libtor.so
+cd ..
+git status
+cd android
+./gradlew clean assembleDebug
⬇️ Suggested change
-./gradlew clean assembleDebug
Seems a bit out of scope to build the whole Android app at the bottom of this script, but I understand having it to confirm things build.
—
Reply to this email directly, [view it on GitHub](#3121 (review)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AFIZYDKPMBE25YUDU66P5AL4PFMWJAVCNFSM6AAAAACWHCKYWSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTQOJVGY2DSOJSGA).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Co-authored-by: Jake McGinty <me@jakebot.org>
Co-authored-by: Jake McGinty <me@jakebot.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.