Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"clone": "0.1.19",
"filed": "0.1.0",
"handlebars": "1.2.1",
"ipaddr.js": "1.5.2",
"kang": "1.1.0",
"less": "1.7.5",
"mime": "1.2.11",
Expand All @@ -34,10 +35,10 @@
"reactify": "1.0.0",
"restify": "4.3.1",
"sdc-clients": "10.2.1",
"ufds": "1.3.0",
"superagent": "0.21.0",
"through": "2.3.4",
"trace-event": "1.3.0",
"ufds": "1.3.0",
"uglify-js": "2.4.16",
"underscore": "1.8.3",
"underscore.string": "3.0.3",
Expand Down
27 changes: 27 additions & 0 deletions www/js/views/network-form.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ require('backbone.syphon');

var _ = require('underscore');
var $ = require('jquery');
var ipaddr = require('ipaddr.js');
var adminui = require('../adminui');

var Template = require('../tpl/networks-form.hbs');
Expand Down Expand Up @@ -198,6 +199,32 @@ var View = Backbone.Marionette.Layout.extend({
var params = {};
var network = this.model.toJSON();

var subnetType;
try {
subnetType = data.subnet && ipaddr.parse(data.subnet.substr(0, data.subnet.indexOf('/'))).kind();
} catch (ex) {
// ignore
}
if (!subnetType) {
this.showError([{field: 'subnet', message: 'Subnet must be in CIDR form'}]);
return;
}
var resolversError = data.resolvers.some(function (resolver) {
var addrType;
try {
addrType = ipaddr.parse(resolver).kind();
} catch (ex) {
// ignore
}

return !addrType || subnetType !== addrType;
});

if (resolversError) {
this.showError([{field: 'resolvers', message: 'resolvers should match subnet type'}]);
return;
}

if (this.model.isNew()) {
this.model.set(data);
this.model.save().done(self.onSaved.bind(self)).fail(self.onError.bind(self));
Expand Down