feat(rapier): full collider shapes support#1403
Open
Neosoulink wants to merge 3 commits intomainfrom
Open
Conversation
### Description - `RigidBody` component now uses `RigidBodyCollidersShape` via the `collider` prop to generate auto colliders - Supported shapes: `cuboid`, `ball`, `capsule`, `cone`, `cylinder`, `convexHull`, `trimesh` - Full Collider Shapes support - Supported `ColliderShape`: `ball`, `capsule`, `cone`, `convexHull`, `convexMesh`, `cuboid`, `cylinder`, `heightfield`, `polyline`, `roundCone`, `roundConvexHull`, `roundConvexMesh`, `roundCuboid`, `roundCylinder`, `trimesh` - Align `Collider` components with `ColliderShape` - Code clean up and accessibility improvements. #### Breaking changes This integration was designed to be backwards compatible, but some changes were necessary to align with the new `ColliderShape`. - Old `Hull` collider no longer supported, use `convexHull` instead.
✅ Deploy Preview for tresjs-lab ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for tresjs-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cientos-tresjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@tresjs/cientos
@tresjs/core
@tresjs/eslint-config
@tresjs/leches
@tresjs/nuxt
@tresjs/post-processing
commit: |
Member
JaimeTorrealba
left a comment
JaimeTorrealba
left a comment
There was a problem hiding this comment.
Sorry the delay man, I was busy and this is a BIG PR, I was testing on details, the types, and the behaivor and LGTM, this is an amazing job, you even take the time to improve types and naming, thanks for that.
I got only three comments:
- After we merge #1395 I think there will be some conflicts (this is the main reason I don't approve this one right now for me is good to go)
- The example of Heightfield is well... useless, I think we can improve this one adding all the new shapes falling to the heightfield or something similar, you know to show the new shapes
- There's no docs. I know we discuss about it but fractly the way I see the changes on the docs are all minor (removing the hull, and add the new shapes to the props) I would prefer you doing it here
Member
Author
No worries @JaimeTorrealba!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RigidBodycomponent now usesRigidBodyCollidersShapevia thecolliderprop to generate auto colliderscuboid,ball,capsule,cone,cylinder,convexHull,trimesh.ColliderShape:ball,capsule,cone,convexHull,convexMesh,cuboid,cylinder,heightfield,polyline,roundCone,roundConvexHull,roundConvexMesh,roundCuboid,roundCylinder,trimesh.Collidercomponents withColliderShape.Breaking changes
This integration was designed to be backwards compatible, but some changes were necessary to align with the new
ColliderShape.hullcollider no longer supported, useconvexHullinstead.