Fix contract datatype

.ci-config/rippled.cfg

@@ -101,7 +101,6 @@ online_delete=256
 # Devnet amendments as of June 28th, 2023
 NegativeUNL
 fixRemoveNFTokenAutoTrustLine
-NonFungibleTokensV1
 CheckCashMakesTrustLine
 fixRmSmallIncreasedQOffers
 fixSTAmountCanonicalize
@@ -144,10 +143,8 @@ fix1512
 fix1373
 MultiSign
 Checks
-NonFungibleTokensV1_1
 # 1.10.0 Amendments
 DisallowIncoming
-fixNonFungibleTokensV1_2
 fixTrustLinesToSelf
 fixUniversalNumber
 ImmediateOfferKilled
@@ -158,7 +155,6 @@ ExpandedSignerList
 AMM
 Clawback
 fixReducedOffersV1
-fixNFTokenRemint
 # 2.0.0 Amendments
 XChainBridge
 DID
@@ -188,11 +184,12 @@ PermissionedDomains
 fixFrozenLPTokenTransfer
 fixInvalidTxFlags
 # 2.5.0 Amendments
-PermissionDelegation
 Batch
 PermissionedDEX
 TokenEscrow
 SingleAssetVault
+LendingProtocol
+PermissionDelegationV1_1
 
 # This section can be used to simulate various FeeSettings scenarios for rippled node in standalone mode
 [voting]

.github/dependabot.yml

@@ -3,6 +3,6 @@ updates:
 - package-ecosystem: npm
   directory: "/"
   schedule:
-    interval: weekly
+    interval: quarterly
     time: "15:00"
-  open-pull-requests-limit: 10
+  open-pull-requests-limit: 30

.github/workflows/faucet_test.yml

@@ -10,10 +10,16 @@ on:
         description: 'Git ref to checkout (branch, tag, or commit SHA)'
         required: true
         type: string
+      run_faucet_tests:
+        description: 'Run faucet tests job'
+        required: false
+        type: boolean
+        default: true
 
 
 jobs:
   faucet-test:
+    if: ${{ github.event_name != 'workflow_dispatch' || inputs.run_faucet_tests != false }}
     runs-on: ubuntu-latest
     timeout-minutes: 15
 

.github/workflows/generate-documentation.yml

@@ -0,0 +1,77 @@
+name: Generate Documentation
+
+on:
+  workflow_call:
+    inputs:
+      git_ref:
+        description: 'Git ref to checkout (branch, tag, or commit SHA)'
+        required: true
+        type: string
+
+env:
+  GIT_REF: ${{ inputs.git_ref }}
+
+jobs:
+  generate-documentation:
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        node-version: [22.x]
+
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          ref: ${{ env.GIT_REF }}
+          fetch-depth: 0
+
+      - name: Use Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v4
+        with:
+          node-version: ${{ matrix.node-version }}
+
+      - name: Setup npm version 10
+        run: |
+          npm i -g npm@10 --registry=https://registry.npmjs.org
+      - name: Cache node modules
+        id: cache-nodemodules
+        uses: actions/cache@v4
+        env:
+          cache-name: cache-node-modules
+        with:
+          # caching node_modules
+          path: |
+            node_modules
+            */*/node_modules
+          key: ${{ runner.os }}-deps-${{ matrix.node-version }}-${{ hashFiles('**/package-lock.json') }}
+          restore-keys: |
+            ${{ runner.os }}-deps-${{ matrix.node-version }}-
+      - name: Install Dependencies
+        if: steps.cache-nodemodules.outputs.cache-hit != 'true'
+        run: npm ci
+
+      - run: npm run build
+
+      - name: Generate Documentation
+        run: npm run docgen
+
+      - name: Upload documentation files as artifact
+        id: docs-artifact
+        uses: actions/upload-pages-artifact@v3
+        with:
+          path: docs/
+          retention-days: 10
+
+  deploy-docs-pages:
+    permissions:
+      id-token: write  # Needed for OIDC authentication
+      pages: write # this permission is needed for deploying into Github Pages
+    environment:
+      name: github-pages
+      url: ${{ steps.docs-artifact.outputs.page_url }}
+    runs-on: ubuntu-latest
+    needs: generate-documentation
+    steps:
+      - name: Deploy to Documentation to GitHub Pages
+        id: docs-artifact
+        uses: actions/deploy-pages@v4

.github/workflows/nodejs.yml

@@ -11,23 +11,39 @@ on:
   push:
     branches: [main]
     tags:
-      - '**'
+      - "**"
   pull_request:
+    types: [opened, synchronize, reopened, ready_for_review]
   workflow_dispatch:
   workflow_call:
     inputs:
       git_ref:
-        description: 'Git ref to checkout (branch, tag, or commit SHA)'
+        description: "Git ref to checkout (branch, tag, or commit SHA)"
         required: true
         type: string
+      run_unit_tests:
+        description: "Run unit tests job"
+        required: false
+        type: boolean
+        default: true
+      run_integration_tests:
+        description: "Run integration tests job"
+        required: false
+        type: boolean
+        default: true
+      run_browser_tests:
+        description: "Run browser tests job"
+        required: false
+        type: boolean
+        default: true
 
 jobs:
   build-and-lint:
     runs-on: ubuntu-latest
     timeout-minutes: 10
     strategy:
       matrix:
-        node-version: [22.x]
+        node-version: [24.x]
 
     steps:
       - uses: actions/checkout@v4
@@ -65,12 +81,13 @@ jobs:
       - run: npm run lint
 
   unit:
+    if: ${{ github.event_name != 'workflow_dispatch' || inputs.run_unit_tests != false }}
     runs-on: ubuntu-latest
     timeout-minutes: 10
 
     strategy:
       matrix:
-        node-version: [20.x, 22.x]
+        node-version: [20.x, 22.x, 24.x]
 
     steps:
       - uses: actions/checkout@v4
@@ -108,12 +125,13 @@ jobs:
       - run: npm test
 
   integration:
+    if: ${{ github.event_name != 'workflow_dispatch' || inputs.run_integration_tests != false }}
     runs-on: ubuntu-latest
     timeout-minutes: 10
 
     strategy:
       matrix:
-        node-version: [20.x, 22.x]
+        node-version: [20.x, 22.x, 24.x]
 
     steps:
       - uses: actions/checkout@v4
@@ -123,7 +141,7 @@ jobs:
 
       - name: Run docker in background
         run: |
-          docker run --detach --rm -p 6006:6006 --volume "${{ github.workspace }}/.ci-config/":"/etc/opt/ripple/" --name rippled-service --health-cmd="rippled server_info || exit 1" --health-interval=5s --health-retries=10 --health-timeout=2s --env GITHUB_ACTIONS=true --env CI=true --entrypoint bash ${{ env.RIPPLED_DOCKER_IMAGE }} -c "rippled -a"
+          docker run --detach --rm -p 6006:6006 --volume "${{ github.workspace }}/.ci-config/":"/etc/opt/ripple/" --name rippled-service --health-cmd="rippled server_info || exit 1" --health-interval=5s --health-retries=10 --health-timeout=2s --env GITHUB_ACTIONS=true --env CI=true --entrypoint bash ${{ env.RIPPLED_DOCKER_IMAGE }} -c "mkdir -p /var/lib/rippled/db/ && rippled -a"
 
       - name: Use Node.js ${{ matrix.node-version }}
         uses: actions/setup-node@v4
@@ -162,12 +180,13 @@ jobs:
         run: docker stop rippled-service
 
   browser:
+    if: ${{ github.event_name != 'workflow_dispatch' || inputs.run_browser_tests != false }}
     runs-on: ubuntu-latest
     timeout-minutes: 10
 
     strategy:
       matrix:
-        node-version: [22.x]
+        node-version: [24.x]
 
     steps:
       - uses: actions/checkout@v4
@@ -182,7 +201,7 @@ jobs:
 
       - name: Run docker in background
         run: |
-          docker run --detach --rm -p 6006:6006 --volume "${{ github.workspace }}/.ci-config/":"/etc/opt/ripple/" --name rippled-service --health-cmd="rippled server_info || exit 1" --health-interval=5s --health-retries=10 --health-timeout=2s --env GITHUB_ACTIONS=true --env CI=true --entrypoint bash ${{ env.RIPPLED_DOCKER_IMAGE }} -c "rippled -a"
+          docker run --detach --rm -p 6006:6006 --volume "${{ github.workspace }}/.ci-config/":"/etc/opt/ripple/" --name rippled-service --health-cmd="rippled server_info || exit 1" --health-interval=5s --health-retries=10 --health-timeout=2s --env GITHUB_ACTIONS=true --env CI=true --entrypoint bash ${{ env.RIPPLED_DOCKER_IMAGE }} -c "mkdir -p /var/lib/rippled/db/ && rippled -a"
 
       - name: Setup npm version 10
         run: |
@@ -214,79 +233,3 @@ jobs:
       - name: Stop docker container
         if: always()
         run: docker stop rippled-service
-
-  generate-documentation:
-    runs-on: ubuntu-latest
-
-    strategy:
-      matrix:
-        node-version: [22.x]
-
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          ref: ${{ env.GIT_REF }}
-          fetch-depth: 0
-
-      - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v4
-        with:
-          node-version: ${{ matrix.node-version }}
-
-      - name: Setup npm version 10
-        run: |
-          npm i -g npm@10 --registry=https://registry.npmjs.org
-
-      - name: Cache node modules
-        id: cache-nodemodules
-        uses: actions/cache@v4
-        env:
-          cache-name: cache-node-modules
-        with:
-          # caching node_modules
-          path: |
-            node_modules
-            */*/node_modules
-          key: ${{ runner.os }}-deps-${{ matrix.node-version }}-${{ hashFiles('**/package-lock.json') }}
-          restore-keys: |
-            ${{ runner.os }}-deps-${{ matrix.node-version }}-
-
-      - name: Install Dependencies
-        if: steps.cache-nodemodules.outputs.cache-hit != 'true'
-        run: npm ci
-
-      - run: npm run build
-
-      - name: Generate Documentation
-        run: npm run docgen
-
-      - name: Upload documentation files as artifact
-        id: docs-artifact
-        uses: actions/upload-pages-artifact@v3
-        with:
-          path: docs/
-          retention-days: 10
-
-  deploy-docs-pages:
-    permissions:
-      id-token: write  # Needed for OIDC authentication
-      pages: write # this permission is needed for deploying into Github Pages
-    environment:
-      name: github-pages
-      url: ${{ steps.docs-artifact.outputs.page_url }}
-    runs-on: ubuntu-latest
-    needs: generate-documentation
-    # Deploy docs only pushes into the main branch
-    if: success() && github.ref == 'refs/heads/main'
-    steps:
-      - name: Detect (non-beta) version tag
-        id: check-tag
-        run: |
-          if [[ ${{ github.event.ref }} =~ ^refs/tags/v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
-              echo "published_version_tag=true" >> $GITHUB_OUTPUT
-          fi
-
-      - name: Deploy to Documentation to GitHub Pages
-        id: docs-artifact
-        if: steps.check-tag.outputs.published_version_tag == 'true'
-        uses: actions/deploy-pages@v4