Open
Conversation
The tap-wasm/pkg/ directory is gitignored, so WASM binaries could become stale after Rust changes (e.g., Flattened JWS serialization). This adds a build:wasm script and pretest hook to ensure fresh WASM on every build and test run. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build:wasmscript that always rebuilds WASM viawasm-packand copies output totap-ts/wasm/pretesthook sonpm testalways gets fresh WASM binariesbuild:wasmintonpm run buildso builds always use current Rust codeprepare-publish.shto delegate WASM building to the new scriptFixes 27 test failures caused by stale WASM binaries after the Flattened JWS serialization change (
a3d9306).Test plan
npm run buildrebuilds WASM and compiles TypeScriptnpm testpasses all 134 tests (pretest rebuilds WASM)cargo fmt --all --checkpassesRUSTFLAGS="-D warnings" cargo clippy --workspace --all-targets --releasepassesRUSTFLAGS="-D warnings" cargo test --workspace --all-targets --releasepasses🤖 Generated with Claude Code