Conversation
Add [Unreleased] section to root CHANGELOG.md and tap-ts/CHANGELOG.md covering PRs #34-#36: security audit fixes (14 findings including critical SQL injection), Flattened JWS and X25519 JWE for Veramo interoperability, and external secret helper for key management. https://claude.ai/code/session_01U5pusfFsLrcwHqZjFhfb8L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces significant improvements to key management, cryptographic interoperability, and security across the TAP agent ecosystem. The changes enable external secret provisioning via git-like helpers, improve Veramo compatibility through JWS format standardization, add X25519 support for JWE operations, and address multiple security vulnerabilities.
Key Changes
External Secret Helper for Key Management
get_private_key(did)method toAgentKeyManagerandKeyManagertraitsecret_helpermodule withSecretHelperConfiganddiscover_agent_didsfunctionalityTapAgent::from_secret_helper()factory method for external key provisioning--secret-helper/TAP_SECRET_HELPERflag across tap-cli, tap-http, and tap-mcpFlattened JWS Serialization for Veramo Compatibility
base64_decode_flexible()helper supporting all Base64 variants (standard, URL-safe, padded/unpadded)did:keyresolution inresolve_verification_keyfor cross-agent signature verificationX25519 JWE Anoncrypt Support
x25519-dalekfor Veramo JWE interoperabilityunwrap_jwealongside existing P-256apv/apufields optional inJweProtected(Veramo omits them)Security Fixes
PRAGMA query_only=ONto prevent SQL read-only filter bypassurlencodingcratehappy-domto v20 to fix critical VM escape vulnerability (tap-ts)Bug Fixes
unwrapon database deserialization with proper error handlingurlencodingcrateEncoding Changes
https://claude.ai/code/session_01U5pusfFsLrcwHqZjFhfb8L