Closed
Conversation
Update workspace version and all inter-crate dependency versions from 0.5.0 to 0.6.0. Add clear installation instructions (crates.io, from source, verify) to all CLI tool READMEs and `cargo add` sections to library crate READMEs. Reorganize root README Getting Started with explicit install paths and add tap-mcp to CLI tools listing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Adds a git-like secret helper pattern that allows TAP agents to retrieve private keys from external secret stores (HashiCorp Vault, AWS KMS, 1Password). - Add get_private_key(did) to AgentKeyManager and KeyManager trait - Add secret_helper module with SecretHelperConfig and discover_agent_dids - Add from_secret_helper() factory on TapAgent - Add --secret-helper / TAP_SECRET_HELPER flag to tap-cli, tap-http, tap-mcp - Simplify WASM export_private_key() to use new get_private_key() Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Drop file handles and call sync_all() before executing scripts to prevent "Text file busy" errors on macOS. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_private_key(did)toAgentKeyManagerandKeyManagertrait for extracting raw private key bytes from both generated keys and stored JWK secretssecret_helpermodule (tap-agent) with a git-like pattern for retrieving private keys from external secret stores (HashiCorp Vault, AWS KMS, 1Password, etc.)from_secret_helper()factory onTapAgentfor creating agents from external key sources--secret-helper/TAP_SECRET_HELPERCLI flag totap-cli,tap-http, andtap-mcpexport_private_key()to use the newget_private_key()methodSecret Helper Protocol
The secret helper is invoked as
<command> [args...] <did>and outputs JSON to stdout:{"private_key": "abcdef...", "key_type": "Ed25519", "encoding": "hex"}Supports
hexandbase64encodings, andEd25519,P256,Secp256k1key types.Test plan
get_private_key()tests: generated keys, storage-loaded keys, P256, Secp256k1, unknown DID, roundtripcargo fmt --all --checkRUSTFLAGS="-D warnings" cargo clippy --workspace --all-targets --releaseRUSTFLAGS="-D warnings" cargo test --workspace --lib --tests --releasecd tap-ts && npm ci && npm test(134/134 pass)🤖 Generated with Claude Code