fix: correct ButtonColors and button dimensions on Drift Net Fishing interface#258
Open
orkabyte wants to merge 1 commit intoTorwent:masterfrom
Open
fix: correct ButtonColors and button dimensions on Drift Net Fishing interface#258orkabyte wants to merge 1 commit intoTorwent:masterfrom
orkabyte wants to merge 1 commit intoTorwent:masterfrom
Conversation
Wrong ButtonColors and button dimensions caused GetButtons() to return an empty array for regular buttons, making GetButton() non-functional. - Fix ButtonColors: CTS1(2370349,0)/CTS1(1052431,26) → CTS1(5334129,2)/CTS1(657930,20) - Fix regular button dims: [[36,36]] → [[33,34],[34,34]] - Fix overlay button dims: [100,30] → [100,28] (precision correction)
orkabyte
changed the title
orkabyte
changed the title
orkabyte
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes button detection in the Drift Net Fishing interface. GetButtons() was returning an empty array for the regular buttons (discard/bank/take), making GetButton() non-functional for the primary interface.
Critical Fixes
BEFORE
CTS1(2370349, 0)
AFTER - Corrected to CTS1(5334129, 2)
Precision Fix
Overlay button dimensions: [100, 30] → [100, 28]. Corrected to actual measured height. The old value only worked previously due to FindButtons tolerance.
Tests
BEFORE
AFTER
These corrections have been validated over 50+ hours of live drift net fishing with no detection failures.