Efficient masked inference#1007
Closed
measty wants to merge 5 commits intodev-define-engines-abcfrom
Closed
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-define-engines-abc #1007 +/- ##
=========================================================
Coverage ? 99.21%
=========================================================
Files ? 83
Lines ? 11356
Branches ? 1503
=========================================================
Hits ? 11267
Misses ? 54
Partials ? 35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shaneahmed
reviewed
Feb 26, 2026
| curr_chunk[-overlap:] += next_chunk[:overlap] | ||
| curr_count[-overlap:] += next_count[:overlap] | ||
| for i, overlap_ in enumerate(tqdm_loop): | ||
| overlap = int(overlap_) |
Member
There was a problem hiding this comment.
Since I shift all the coordinates to new masked coordinates, positive overlap is not required in #1006
shaneahmed
reviewed
Feb 26, 2026
| Array of output locations for each patch. | ||
| change_indices (np.ndarray | list[np.ndarray]): | ||
| Indices indicating where to flush and merge patches. | ||
| x_offset (int | None): |
Member
There was a problem hiding this comment.
Since I shift all the coordinates to new masked coordinates, x_offset is not required in #1006
shaneahmed
reviewed
Feb 26, 2026
| output_locs: np.ndarray, | ||
| change_indices: np.ndarray | list[int], | ||
| x_offset: int | None = None, | ||
| canvas_width: int | None = None, |
shaneahmed
reviewed
Feb 26, 2026
| update_ui_on_new_annotations(ann_types) | ||
|
|
||
| # Clean up temp files | ||
| rmtree(tmp_save_dir) |
Member
There was a problem hiding this comment.
Not sure, why this change in this PR.
shaneahmed
added a commit
that referenced
this pull request
Feb 26, 2026
- Add canvas width to merge horizontal
shaneahmed
reviewed
Feb 26, 2026
| if hasattr(dataloader.dataset, "full_outputs") | ||
| else dataloader.dataset.outputs | ||
| ) | ||
| active_output_locs = _get_dataset_output_locs(dataloader.dataset) |
shaneahmed
reviewed
Feb 26, 2026
| canvas_np, | ||
| output_locs, | ||
| change_indices, | ||
| x_offset=canvas_x_start, |
Member
There was a problem hiding this comment.
Not required in #1006 due to new masked coordinates.
shaneahmed
reviewed
Feb 26, 2026
| output_locs, | ||
| change_indices, | ||
| x_offset=canvas_x_start, | ||
| canvas_width=canvas_width, |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
draft masked inference PR - take any ideas that are useful from here