Fix abort on inverted time travel query#890
Open
alancleary wants to merge 1 commit intomainfrom
Open
Conversation
Time-travel queries are supposed to return an empty result set when the time range is empty. This extends to inverted ranges as well, i.e. an empty result set is always returned when the start time is after the end time. However, the underlying TileDB query actually aborts when an inverted range is given. This was usually missed by CI because the test was so small that the start and end wall clock times used were the same, resulting in the expected behaviour. This commit fixes the issue by short circuiting and skipping the TileDB query altogether when the range is inverted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small PR that fixes a recurring CI failure.
Time-travel queries are supposed to return an empty result set when the time range is empty. This extends to inverted ranges as well, i.e. an empty result set is always returned when the start time is after the end time. However, the underlying TileDB query actually aborts when an inverted range is given. This was usually missed by CI because the test was so small that the start and end wall clock times used were the same, resulting in the expected behaviour. This commit fixes the issue by short circuiting and skipping the TileDB query altogether when the range is inverted.