Skip to content

remove ask-ai#159

Merged
DIodide merged 1 commit intomainfrom
feat/gateway
Mar 26, 2026
Merged

remove ask-ai#159
DIodide merged 1 commit intomainfrom
feat/gateway

Conversation

@DIodide
Copy link
Copy Markdown
Member

@DIodide DIodide commented Mar 26, 2026

remove ask ai from junction

@DIodide DIodide self-assigned this Mar 26, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: df29e81252

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

{
"code": "upstream_error",
"message": "The language model dependency failed.",
"message": f"LLM error: {exc}",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep upstream LLM details out of client-visible errors

Returning f"LLM error: {exc}" to the SSE client leaks raw provider error text; LlmClientError is raised with full OpenRouter HTTP bodies in OpenAiLlmClient (including whatever the upstream sends back), so end users can now receive internal dependency details that were previously hidden behind a generic message. This is a regression in error-surface safety and should be limited to logs while keeping the public error.message generic.

Useful? React with 👍 / 👎.

@DIodide DIodide merged commit 289120b into main Mar 26, 2026
1 check passed
@DIodide DIodide deleted the feat/gateway branch March 26, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant