Fix bugs in UpgradeService#699
Open
bharatvansh wants to merge 1 commit intoTichau:integrationfrom
Open
Conversation
UCHIHAHA103
pushed a commit
to UCHIHAHA103/FileConverter
that referenced
this pull request
Apr 26, 2026
1. Cherry-pick PR Tichau#699 fixes: - CheckForUpgrade: null-check 'task' before await (NullReferenceException) - DownloadLatestVersionDescription: fix Helpers.BaseURI -> UpgradeService.BaseURI Fixes Tichau#747 2. Update BaseURI to point to UCHIHAHA103/FileConverter fork so users receive updates from this fork instead of the original repo. Update version.xml and version (x86).xml URLs accordingly. 3. Complete zh-CN translations: add 8 missing hardware acceleration mode strings (HardwareAccelerationMode, CUDA, AMF, D3D11, DXVA2, Off, OpenCL, Vulkan). Co-authored-by: bharatvansh <bharatvansh@users.noreply.github.com> Co-authored-by: sr093906 <sr093906@users.noreply.github.com>
UCHIHAHA103
pushed a commit
to UCHIHAHA103/FileConverter
that referenced
this pull request
Apr 29, 2026
…eckForUpgrade + DownloadProgressChanged safety - BaseURI: Tichau/FileConverter -> UCHIHAHA103/FileConverter (users were being redirected to upstream releases instead of fork releases) - CheckForUpgrade: add null check for task before await (PR Tichau#699 fix, Release mode skips check if < 1 day since last check -> task is null) - DownloadInstaller: unsubscribe DownloadProgressChanged before setting UpgradeVersionDescription to null (prevents NullRef in callback) - WebClient_DownloadProgressChanged: null-guard UpgradeVersionDescription - ISSUES_BACKLOG.md: document right-click menu root cause analysis, update Sprint 1 status
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs in
UpgradeService:taskinCheckForUpgradebefore awaiting it. Iftaskis null (e.g., if the upgrade check is not due yet or an error occurred), the method now correctly returns null.Helpers.BaseURIinDownloadLatestVersionDescriptionwhich was causing a compilation error. It has been replaced with the correctUpgradeService.BaseURIreference.