Conversation
feat: allow to print_pdf
* ci: testing in dev too * feat: allow to print_pdf * test: testing pdf printing * chore: version bump & news * Update NEWS.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* feat: retry the quarto rendering with purrr::insistently * fix: rule number 1 * feat: pass param for insistently * fix: future settings are by default sequential * test: fixing the tests for fetch_future_settings
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
==========================================
+ Coverage 98.96% 98.97% +0.01%
==========================================
Files 12 12
Lines 385 390 +5
==========================================
+ Hits 381 386 +5
Misses 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the NEWS.md file to document new release notes for squash 1.2.0. It includes a new changelog entry describing the updated Qmd rendering approach using purrr::insistently() and clarifies that the rendering functions are now configurable.
Files not reviewed (7)
- DESCRIPTION: Language not supported
- R/compile_qmd_course.R: Language not supported
- R/fetch_future_settings.R: Language not supported
- R/render_single_qmd.R: Language not supported
- man/compile_qmd_course.Rd: Language not supported
- man/render_single_qmd.Rd: Language not supported
- tests/testthat/test-fetch_future_settings.R: Language not supported
Comments suppressed due to low confidence (1)
NEWS.md:3
- [nitpick] Consider verifying the use of the adverb 'insistently' to ensure it accurately reflects the intended behavior, as it might be interpreted ambiguously.
* The rendering of the Qmd is now performed insistently with purrr::insistently(), and can be configured in the rendering functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.