Conversation
- PresignedUrlService: 불필요한 INFO 로그 삭제, error → event= 포맷 (generateUploadUrl/downloadUrl INFO 제거, presigned_upload_url_fail, presigned_download_url_fail, s3_check_fail 이벤트 코드 적용) - GlobalExceptionHandler: 자유 형식 → event= 포맷 통일 (PresignedUrlException 중복 로그 제거, resource_not_found, validation_error, token_expired, unauthorized_access, invalid_input, unexpected_error 이벤트 코드 적용) - UserCleanupScheduler: [UserCleanup] 접두사 → event= 포맷 통일 (scheduler_user_deleted, scheduler_user_cleanup_done, scheduler_token_cleanup_done, 대상 없을 때 불필요 INFO 제거)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PresignedUrlService: 불필요한 INFO 로그 삭제 및 error 로그 event= 포맷 적용GlobalExceptionHandler: 자유 형식 로그 → event= 포맷 통일,PresignedUrlException중복 로그 제거UserCleanupScheduler:[UserCleanup]접두사 → event= 포맷 통일변경 상세
PresignedUrlService
generateUploadUrl/generateDownloadUrlINFO 로그 삭제 (상위 서비스 이벤트에서 커버)event=presigned_upload_url_fail,event=presigned_download_url_fail,event=s3_check_fail적용checkFileExistsdebug 로그 유지GlobalExceptionHandler
PresignedUrlException핸들러 로그 삭제 (PresignedUrlService에서 중복 로깅)event=resource_not_found,event=validation_error,event=token_expired,event=unauthorized_access,event=invalid_input,event=unexpected_error적용UserCleanupScheduler
event=scheduler_user_deleted,event=scheduler_user_cleanup_done,event=scheduler_token_cleanup_done적용Test plan
event=presigned_upload_url_fail로그 확인event=resource_not_found로그 확인event=unexpected_error+ 스택트레이스 확인