fix: use HasPrefix for text/event-stream content-type check#201
Merged
jesse-engineer merged 1 commit intoMay 15, 2026
Merged
Conversation
Some servers or reverse proxies (e.g., nginx) append '; charset=utf-8' to the Content-Type header, resulting in 'text/event-stream; charset=utf-8'. The strict equality check fails in this case, causing the error: 'unexpected content type: text/event-stream; charset=utf-8'. Use strings.HasPrefix for text/event-stream check, consistent with how application/json is already handled. Fixes ThinkInAIXYZ#200
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug fix
What this PR does
Fix the
unexpected content type: text/event-stream; charset=utf-8error when servers or reverse proxies (e.g., nginx) append; charset=utf-8to theContent-Typeheader.Root Cause
In
transport/streamable_http_client.go, the client checksContent-Typefortext/event-streamusing strict equality (==). When the server returnstext/event-stream; charset=utf-8(which is valid HTTP), the check fails and falls into thedefaultcase, producing the error.The
application/jsoncheck already usesstrings.HasPrefix, buttext/event-streamdid not.Changes
!strings.HasPrefix(resp.Header.Get("Content-Type"), "text/event-stream")strings.HasPrefix(contentType, "text/event-stream")Which issue(s) this PR fixes
Fixes #200