Update the config init script to handle both the profiles#61
Open
Lunchb0ne wants to merge 1 commit intoTheRandomLabs:masterfrom
Open
Update the config init script to handle both the profiles#61Lunchb0ne wants to merge 1 commit intoTheRandomLabs:masterfrom
Lunchb0ne wants to merge 1 commit intoTheRandomLabs:masterfrom
Conversation
Now that we have 2 versions of the config script, for backwards compatibility sake, we should check for both and only add the extensions and stuff when we need to, otherwise we can end up with something like this ``` extensions = default-dynamic.js|Vibrant.min.js|bookmark.js|fullAppDisplay.js|keyboardShortcut.js|shuffle+.js|trashbin.js|webnowplaying.js|autoSkipExplicit.js|bookmark.js|fullAppDisplay.js|keyboardShortcut.js|newRelease.js|queueAll.js|shuffle+.js|trashbin.js|webnowplaying.js ```
o1x3
added a commit
to o1x3/Scoop-Spotify
that referenced
this pull request
Oct 30, 2021
modified: scripts/init-spicetify-config.ps1 credits to: TheRandomLabs#61
|
I've fixed this issue but since @TheRandomLabs is not responding I've forked this repo and added all the fixes there. Feel free to check it out if you need it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we have 2 versions of the config script, for backwards compatibility sake, we should check for both and only add the extensions and stuff when we need to, otherwise we can end up with something like this