Closing handles, freeing memory and preventing unneeded file opens#149
Open
sjoblomj wants to merge 1 commit intoTheGrayDot:mainfrom
Open
Closing handles, freeing memory and preventing unneeded file opens#149sjoblomj wants to merge 1 commit intoTheGrayDot:mainfrom
sjoblomj wants to merge 1 commit intoTheGrayDot:mainfrom
Conversation
sjoblomj
commented
Mar 3, 2026
Comment on lines
-98
to
-103
| HANDLE hFile; | ||
| if (!SFileOpenFileEx(hArchive, szFileName, SFILE_OPEN_FROM_MPQ, &hFile)) { | ||
| std::cerr << "[!] Failed: File cannot be opened: " << szFileName << std::endl; | ||
| return 1; | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
The call to SFileExtractFile below already does this under the hood. These lines don't add anything I believe.
Comment on lines
-355
to
+350
| LCID * fileLocales = (LCID *)malloc(maxLocales * sizeof(LCID)); | ||
| const auto fileLocales = static_cast<LCID *>(malloc(maxLocales * sizeof(LCID))); |
Contributor
Author
There was a problem hiding this comment.
This seems like a cleaner way to allocate memory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.