Skip to content

fix: keep pangram checks ASCII-scoped #14687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sean-Kenneth-Doherty wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −5
Open

fix: keep pangram checks ASCII-scoped #14687

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions strings/is_pangram.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ def is_pangram(
False
>>> is_pangram("The quick brown fox jumps over the la_y dog")
False
>>> is_pangram("abcdefghijklmnopqrstuvwxy\\u00e9")
False
>>> is_pangram()
True
"""
Expand All @@ -44,15 +46,16 @@ def is_pangram_faster(
True
>>> is_pangram_faster("The quick brown fox jumps over the la_y dog")
False
>>> is_pangram_faster("abcdefghijklmnopqrstuvwxy\\u00e9")
False
>>> is_pangram_faster()
True
"""
flag = [False] * 26
for char in input_str:
if char.islower():
flag[ord(char) - 97] = True
elif char.isupper():
flag[ord(char) - 65] = True
lower_char = char.lower()
if "a" <= lower_char <= "z":
flag[ord(lower_char) - 97] = True
return all(flag)


Expand All @@ -68,10 +71,12 @@ def is_pangram_fastest(
True
>>> is_pangram_fastest("The quick brown fox jumps over the la_y dog")
False
>>> is_pangram_fastest("abcdefghijklmnopqrstuvwxy\\u00e9")
False
>>> is_pangram_fastest()
True
"""
return len({char for char in input_str.lower() if char.isalpha()}) == 26
return len({char for char in input_str.lower() if "a" <= char <= "z"}) == 26


def benchmark() -> None:
Expand Down