Open
Conversation
cgrgx
added
documentation
Collaborator
There was a problem hiding this comment.
Blob1 ?
Can we try to name something generic?
Collaborator
Author
There was a problem hiding this comment.
Sure, let's try to come up with a more generic and descriptive name.
How about we rename to something like backgroundBlogImage or decorativeElementBlob?
I'm open to other suggestions as well. Please feel free to propose alternative names that you think would be more appropriate and descriptive.
I appreciate you taking the time to review the code and provide feedback.
Thank you Sagar.
Collaborator
There was a problem hiding this comment.
backgroundBlogImage, would be better.
… into feature_landing-page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
optimized images for performance and change assets from public to src folder