Skip to content

honor vulkan extension dependencies#6705

Merged
nihui merged 2 commits intoTencent:masterfrom
nihui:vulkan-ext-deps
May 9, 2026
Merged

honor vulkan extension dependencies#6705
nihui merged 2 commits intoTencent:masterfrom
nihui:vulkan-ext-deps

Conversation

@nihui
Copy link
Copy Markdown
Member

@nihui nihui commented May 8, 2026

No description provided.

@tencent-adm
Copy link
Copy Markdown
Member

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 8, 2026

Codecov Report

❌ Patch coverage is 38.37209% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.56%. Comparing base (8775d9c) to head (e288f6c).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/gpu.cpp 38.37% 53 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6705      +/-   ##
==========================================
- Coverage   93.95%   93.56%   -0.39%     
==========================================
  Files         933      933              
  Lines      299683   299358     -325     
==========================================
- Hits       281556   280104    -1452     
- Misses      18127    19254    +1127     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates NCNN’s Vulkan capability detection to better respect extension dependency chains, and adds tracking/enabling for device-group related extensions.

Changes:

  • Add instance-level tracking for VK_KHR_device_group_creation and device-level tracking/accessor for VK_KHR_device_group.
  • Introduce dependency-based filtering to mask out extensions whose prerequisites are not met.
  • Enable VK_KHR_device_group_creation at instance creation and VK_KHR_device_group at device creation when supported.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/gpu.h Declares new Vulkan extension support globals and a new GpuInfo accessor for device-group support.
src/gpu.cpp Implements new extension support variables, dependency filtering, instance/device extension enabling, and the new GpuInfo accessor.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/gpu.cpp Outdated
Comment thread src/gpu.cpp
@nihui nihui merged commit 4e9fec3 into Tencent:master May 9, 2026
105 of 109 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants