honor vulkan extension dependencies#6705
Conversation
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6705 +/- ##
==========================================
- Coverage 93.95% 93.56% -0.39%
==========================================
Files 933 933
Lines 299683 299358 -325
==========================================
- Hits 281556 280104 -1452
- Misses 18127 19254 +1127 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Updates NCNN’s Vulkan capability detection to better respect extension dependency chains, and adds tracking/enabling for device-group related extensions.
Changes:
- Add instance-level tracking for
VK_KHR_device_group_creationand device-level tracking/accessor forVK_KHR_device_group. - Introduce dependency-based filtering to mask out extensions whose prerequisites are not met.
- Enable
VK_KHR_device_group_creationat instance creation andVK_KHR_device_groupat device creation when supported.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/gpu.h | Declares new Vulkan extension support globals and a new GpuInfo accessor for device-group support. |
| src/gpu.cpp | Implements new extension support variables, dependency filtering, instance/device extension enabling, and the new GpuInfo accessor. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.