Skip to content

Precompute packed binary sites and headers in BinaryEncoding#605

Draft
Copilot wants to merge 7 commits into
mainfrom
copilot/precompute-packed-data-headers
Draft

Precompute packed binary sites and headers in BinaryEncoding#605
Copilot wants to merge 7 commits into
mainfrom
copilot/precompute-packed-data-headers

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 14, 2026

  • Inspect the performance harness, Makefile targets, and tracked results files
  • Run the existing performance regeneration target to refresh tracked results
  • Diagnose the regeneration failure in the Python performance worker
  • Fix the packed-site collision causing incorrect packed response decoding
  • Re-run the existing performance regeneration target
  • Review the generated diff and keep only tracked result updates
  • Run final validation and summarize the regenerated results

Copilot AI and others added 2 commits May 14, 2026 20:05
Agent-Logs-Url: https://github.com/Telepact/telepact/sessions/12fe8933-c2b9-4aaf-84fe-803aa5a7e44d

Co-authored-by: brenbar <12563144+brenbar@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Telepact/telepact/sessions/12fe8933-c2b9-4aaf-84fe-803aa5a7e44d

Co-authored-by: brenbar <12563144+brenbar@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Telepact/telepact/sessions/c95c7669-6f21-40c6-8274-0528e873539b

Co-authored-by: brenbar <12563144+brenbar@users.noreply.github.com>
Copilot AI requested a review from brenbar May 18, 2026 02:52
@brenbar
Copy link
Copy Markdown
Collaborator

brenbar commented May 18, 2026

@copilot fix build

Agent-Logs-Url: https://github.com/Telepact/telepact/sessions/111c0e7a-861e-4cb6-999f-bb0673d27d95

Co-authored-by: brenbar <12563144+brenbar@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 18, 2026

@copilot fix build

Fixed in a6f076b. I updated the Go packed-binary unpack path so undefined packed cells no longer leak into validation, aligned the Dart binding test with the emitted empty @pck_ header, and narrowed the nested binary test so it no longer assumes a cross-language packed-site field order.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • accounts.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=14957 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/dart_test_YODZJH --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,6113946608114257196,458380295763643761,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,17647421480541991764,16967535119223283073,4 --trace-process-track-uuid=3190708989122997041 --enable-logging=stderr --v=0 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/dart_test_YODZJH http://localhost:43281/4AOJ6d6spY8=/packages/test/src/REDACTED/browser/static/index.html?managerUrl=ws%3A%2F%2Flocalhost%3A43281%2F4AOJ6d6spY8%3D%2F0&amp;debug=false --enable-logging=stderr --v=0 --disable-extensions --disable-popup-blocking --bwsi --no-first-run --no-default-browser-check --disable-default-apps --disable-translate --disable-dev-shm-usage --headless --disable-gpu --remote-debugging-port=0 V[0]), permittedchmod (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=16227 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/dart_test_JEMMBQ --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,7575757346373934523,9568924339276478308,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,16818961634469148168,3470182405342867997,4 --trace-process-track-uuid=3190708989122997041 --enable-logging=stderr --v=0 (dns block)
  • clients2.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=14957 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/dart_test_YODZJH --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,6113946608114257196,458380295763643761,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,17647421480541991764,16967535119223283073,4 --trace-process-track-uuid=3190708989122997041 --enable-logging=stderr --v=0 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/dart_test_YODZJH http://localhost:43281/4AOJ6d6spY8=/packages/test/src/REDACTED/browser/static/index.html?managerUrl=ws%3A%2F%2Flocalhost%3A43281%2F4AOJ6d6spY8%3D%2F0&amp;debug=false --enable-logging=stderr --v=0 --disable-extensions --disable-popup-blocking --bwsi --no-first-run --no-default-browser-check --disable-default-apps --disable-translate --disable-dev-shm-usage --headless --disable-gpu --remote-debugging-port=0 V[0]), permittedchmod (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=16227 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/dart_test_JEMMBQ --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,7575757346373934523,9568924339276478308,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,16818961634469148168,3470182405342867997,4 --trace-process-track-uuid=3190708989122997041 --enable-logging=stderr --v=0 (dns block)
  • clientservices.googleapis.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=14957 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/dart_test_YODZJH --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,6113946608114257196,458380295763643761,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,17647421480541991764,16967535119223283073,4 --trace-process-track-uuid=3190708989122997041 --enable-logging=stderr --v=0 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/dart_test_YODZJH http://localhost:43281/4AOJ6d6spY8=/packages/test/src/REDACTED/browser/static/index.html?managerUrl=ws%3A%2F%2Flocalhost%3A43281%2F4AOJ6d6spY8%3D%2F0&amp;debug=false --enable-logging=stderr --v=0 --disable-extensions --disable-popup-blocking --bwsi --no-first-run --no-default-browser-check --disable-default-apps --disable-translate --disable-dev-shm-usage --headless --disable-gpu --remote-debugging-port=0 V[0]), permittedchmod (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=16227 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/dart_test_JEMMBQ --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,7575757346373934523,9568924339276478308,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,16818961634469148168,3470182405342867997,4 --trace-process-track-uuid=3190708989122997041 --enable-logging=stderr --v=0 (dns block)
  • example.com
    • Triggering command: /opt/hostedtoolcache/go/1.22.12/x64/bin/go go mod tidy -e -I . /tmp/cgo-gcc-input-1941707870.c sh lse)) l/httpcommon --64 linux_amd64.o x64/�� UnpackList.go internal.telepact.yaml ache/go/1.22.12/x64/pkg/tool/linux_amd64/asm l=ws%3A%2F%2Floc/usr/libexec/gcc/x86_64-linux-gnu/13/cc1 --64 -o ache/go/1.22.12//tmp/go-build3888925053/b103/ (dns block)
    • Triggering command: /opt/hostedtoolcache/go/1.22.12/x64/bin/go go get -v ./... /tmp/go-build3888925053/b103// -dumpbase _cgo_.c -dumpbase-ext .c -m64 -mtune=generic -march=x86-64 x64/�� UnpackList.go internal.telepact.yaml x64/bin/ruby --gdwarf-5 --64 -o ache/go/1.22.12//tmp/go-build3888925053/b103/ (dns block)
  • redirector.gvt1.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=14957 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/dart_test_YODZJH --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,6113946608114257196,458380295763643761,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,17647421480541991764,16967535119223283073,4 --trace-process-track-uuid=3190708989122997041 --enable-logging=stderr --v=0 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/dart_test_YODZJH http://localhost:43281/4AOJ6d6spY8=/packages/test/src/REDACTED/browser/static/index.html?managerUrl=ws%3A%2F%2Flocalhost%3A43281%2F4AOJ6d6spY8%3D%2F0&amp;debug=false --enable-logging=stderr --v=0 --disable-extensions --disable-popup-blocking --bwsi --no-first-run --no-default-browser-check --disable-default-apps --disable-translate --disable-dev-shm-usage --headless --disable-gpu --remote-debugging-port=0 V[0]), permittedchmod (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=16227 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/dart_test_JEMMBQ --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,7575757346373934523,9568924339276478308,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,16818961634469148168,3470182405342867997,4 --trace-process-track-uuid=3190708989122997041 --enable-logging=stderr --v=0 (dns block)
  • safebrowsingohttpgateway.googleapis.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=14957 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/dart_test_YODZJH --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,6113946608114257196,458380295763643761,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,17647421480541991764,16967535119223283073,4 --trace-process-track-uuid=3190708989122997041 --enable-logging=stderr --v=0 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/dart_test_YODZJH http://localhost:43281/4AOJ6d6spY8=/packages/test/src/REDACTED/browser/static/index.html?managerUrl=ws%3A%2F%2Flocalhost%3A43281%2F4AOJ6d6spY8%3D%2F0&amp;debug=false --enable-logging=stderr --v=0 --disable-extensions --disable-popup-blocking --bwsi --no-first-run --no-default-browser-check --disable-default-apps --disable-translate --disable-dev-shm-usage --headless --disable-gpu --remote-debugging-port=0 V[0]), permittedchmod (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=16227 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/dart_test_JEMMBQ --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,7575757346373934523,9568924339276478308,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,16818961634469148168,3470182405342867997,4 --trace-process-track-uuid=3190708989122997041 --enable-logging=stderr --v=0 (dns block)
  • www.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=14957 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/dart_test_YODZJH --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,6113946608114257196,458380295763643761,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,17647421480541991764,16967535119223283073,4 --trace-process-track-uuid=3190708989122997041 --enable-logging=stderr --v=0 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/dart_test_YODZJH http://localhost:43281/4AOJ6d6spY8=/packages/test/src/REDACTED/browser/static/index.html?managerUrl=ws%3A%2F%2Flocalhost%3A43281%2F4AOJ6d6spY8%3D%2F0&amp;debug=false --enable-logging=stderr --v=0 --disable-extensions --disable-popup-blocking --bwsi --no-first-run --no-default-browser-check --disable-default-apps --disable-translate --disable-dev-shm-usage --headless --disable-gpu --remote-debugging-port=0 V[0]), permittedchmod (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=16227 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/dart_test_JEMMBQ --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,7575757346373934523,9568924339276478308,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,16818961634469148168,3470182405342867997,4 --trace-process-track-uuid=3190708989122997041 --enable-logging=stderr --v=0 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI and others added 2 commits May 19, 2026 13:19
Agent-Logs-Url: https://github.com/Telepact/telepact/sessions/8054e2bb-a91f-4145-9944-20f8eaad7f58

Co-authored-by: brenbar <12563144+brenbar@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Telepact/telepact/sessions/8054e2bb-a91f-4145-9944-20f8eaad7f58

Co-authored-by: brenbar <12563144+brenbar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants