✨ LolTimeFlash v2.3.2 - Username Validation & Lobby Refactor#8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Username Validation & Lobby Architecture Refactor
Summary
This release adds comprehensive username validation (3-12 characters) with real-time visual feedback and completely refactors the lobby page following proper atomic component architecture patterns.
New Features
Bug Fixes
Technical Changes
Backend (3 files)
apps/api/libs/shared/src/constants/username.ts- Shared username length constantsapps/api/libs/shared/src/constants/index.ts- Export username constantsapps/api/src/game/dto/join-room.dto.ts- Validation 3-12 characters (local constants for decorator compatibility)Frontend (10 files)
New Components:
features/settings/components/username-validation-feedback.component.tsx- Reusable validation feedback with check/cross iconsfeatures/lobby/components/create-lobby-form.component.tsx- Atomic create lobby formfeatures/lobby/components/join-lobby-form.component.tsx- Atomic join lobby formfeatures/lobby/components/lobby-divider.component.tsx- Memoized divider componentfeatures/lobby/components/index.ts- Barrel exportsRefactored:
features/settings/components/username-input-modal.component.tsx- Integrated validation feedbackapp/settings/page.tsx- Integrated validation feedbackapp/lobby/page.tsx- Reduced from 134 → 28 lines (-78% code reduction)Architecture Improvements:
features/module pattern from AGENTS.mdReact.memo()IprefixUX Improvements:
invisible/visiblepatternmaxLengthto allow validation detectionTesting
Version
2.3.1→2.3.2Breaking Changes
None. This is a backward-compatible patch release.
Ready to merge 🚀