Remove image proxy, add ESLint, fix security issues#398
Draft
Remove image proxy, add ESLint, fix security issues#398
Conversation
- Remove Cloudflare image proxy worker and imageProxy utility; use direct Notion URLs instead - Strip verbose/sensitive console.log calls from notionClient, Events, and api.ts (including PUBLIC_SECRET_KEY leak) - Add security headers to middleware (X-Content-Type-Options, X-Frame-Options, Referrer-Policy); fix Cache-Control override of API routes' no-cache headers - Validate URLs in RichTextRenderer to block javascript:/data: injection - Clamp postMessage iframe height in donate page (100–5000px) - Add ESLint config and .env.example - Fix missing alt attributes on images in ProjectsList
Deploying website with
|
| Latest commit: |
f34a7e7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://26ef3f69.website-aun.pages.dev |
| Branch Preview URL: | https://security-and-cleanup.website-aun.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cloudflare-worker/andsrc/utils/imageProxy.ts;notionClient.tsnow uses direct Notion file URLsjavascript:/data:URLs inRichTextRenderer, clamp postMessage iframe height in donate page, addX-Content-Type-Options/X-Frame-Options/Referrer-Policyheaders to middleware, fix middleware overriding API routes'no-cacheheaders, removePUBLIC_SECRET_KEYconsole leak inapi.tsconsole.logcalls fromnotionClient.tsandEvents.tsxeslint.config.js) and.env.examplealtattributes on images inProjectsListTest plan
X-Content-Type-Options,X-Frame-Options,Referrer-Policy/api/events, etc.) still returnno-cacheheaders (not overridden by middleware)pnpm lintruns without errors