Fix enum variations not resolved for cross-package enum types#110
Merged
Fix enum variations not resolved for cross-package enum types#110
Conversation
Coverage Report for CI Build 24848043446Coverage increased (+0.3%) to 53.278%Details
Uncovered Changes
Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
rafaeljusto
approved these changes
Apr 23, 2026
shane-tw
force-pushed
the
fix/cross-package-enum
branch
from
d8ea766 to
e4361bf
Compare
When a field annotated with {enum} has a type from another package
(e.g. `pkg.SomeType`), getEnumVariations was never called with the
correct type name. The SelectorExpr branch called canonicalType which
resolved the type to its underlying primitive and then jumped back via
goto start; the re-entry then called getEnumVariations with the
primitive name ("string") rather than the original type name
("SomeType"), so no constants were ever matched.
Fix: call getEnumVariations with the original pkg and type name before
executing goto start in the SelectorExpr branch, mirroring what the
Ident branch already does.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
shane-tw
force-pushed
the
fix/cross-package-enum
branch
from
e4361bf to
94f070e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically the automatic enum handling introduced in this PR wasn't working if it was a cross-package enum.
When a field annotated with {enum} has a type from another package (e.g.
pkg.SomeType), getEnumVariations was never called with the correct type name. The SelectorExpr branch called canonicalType which resolved the type to its underlying primitive and then jumped back via goto start; the re-entry then called getEnumVariations with the primitive name ("string") rather than the original type name ("SomeType"), so no constants were ever matched.Fix: call getEnumVariations with the original pkg and type name before executing goto start in the SelectorExpr branch, mirroring what the Ident branch already does.