New and better PID framework for using SmartMotion PID with a CanSparkMax#27
Open
New and better PID framework for using SmartMotion PID with a CanSparkMax#27
Conversation
Contributor
|
@JayAgra could the linter automatically make corrections? |
Member
Author
|
rcahoon
requested changes
Jul 17, 2023
rcahoon
requested changes
Jul 28, 2023
Member
|
there are several instances of code that are noted as being untested (and some as potentially dangerous) since checking code into MaroonFramework implies that it's going to persist for years to come, we generally want to have higher confidence in its reliability. having to-do's in code like this doesn't necessarily block it from being merged, but do you have a plan to revisit this code soon to resolve these issues? |
rcahoon
reviewed
Jul 28, 2023
Member
Author
fixed |
rcahoon
reviewed
Aug 12, 2023
JayAgra
force-pushed
the
CanSparkMaxSmartMotionPIDController
branch
from
f327383 to
21b05d0
Compare
Member
|
the lint failure is expected. @TTVMixmix00 - this branch needs to be rebased to get the latest linter config. |
jamesi8086
reviewed
Sep 13, 2023
jamesi8086
reviewed
Sep 13, 2023
jamesi8086
reviewed
Sep 13, 2023
jamesi8086
reviewed
Sep 13, 2023
jamesi8086
reviewed
Sep 13, 2023
jamesi8086
reviewed
Sep 13, 2023
jamesi8086
reviewed
Sep 23, 2023
| } | ||
|
|
||
| if (comboOfTimesInsideDeadzone >= 6) { | ||
| theState = PIDState.ANTIGRAV; |
Contributor
There was a problem hiding this comment.
we need a flag to disable antigrav if its not needed
also, I realized Brake mode is missing
Contributor
There was a problem hiding this comment.
I think you did not push your changes
Member
Author
There was a problem hiding this comment.
dejabot
pushed a commit
that referenced
this pull request
Dec 30, 2023
initial bringup of RevA robot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically this code takes the rough code that we made during the season and makes it into a class that we are able to instantiate versions of so that new PID code doesn't have to be that hard to follow (or for lack of a better word, bad).
This change is