Skip to content

랜딩페이지 배경 여백 제거#458

Merged
Seong-Myeong merged 1 commit intomainfrom
feature/#442-resize-loginpage-background
Mar 31, 2026
Merged

랜딩페이지 배경 여백 제거#458
Seong-Myeong merged 1 commit intomainfrom
feature/#442-resize-loginpage-background

Conversation

@Seong-Myeong
Copy link
Copy Markdown
Contributor

관련 이슈

PR 설명

  • 현재 물결만 하단에 배치해볼려했으나 고려해야될 부분이 많이 발견되어 물결포함된 배경 이미지를 꽉차게하는 방식으로 변경하였습니다.
  • 변경 내용
    • ic_landing_background.svg 코드상 제거
    • sofa_login_bg_full.svg 를 전체 배경으로 추가

@Seong-Myeong Seong-Myeong linked an issue Mar 26, 2026 that may be closed by this pull request
@Seong-Myeong Seong-Myeong self-assigned this Mar 26, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 26, 2026

Warning

Rate limit exceeded

@Seong-Myeong has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 17 minutes and 24 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: e5910977-aae4-49bf-ac07-670808be721a

📥 Commits

Reviewing files that changed from the base of the PR and between 1e09f07 and 4e20588.

⛔ Files ignored due to path filters (2)
  • src/components/Icons/svgs/ic_landing_background.svg is excluded by !**/*.svg
  • src/components/Icons/svgs/sofa_login_bg_full.svg is excluded by !**/*.svg
📒 Files selected for processing (2)
  • src/app/LandingPage.tsx
  • svgr.d.ts

Walkthrough

로그인 페이지의 배경 SVG를 기존 요소에서 새로운 SofaLoginBackgroundFull SVG로 변경했습니다. 새 배경을 절대 위치로 설정된 컨테이너에 배치하여 전체 수직 공간(inset-y-0)을 차지하도록 하고, 수평 크기를 확대(w-[103vw], -right-[3vw])했습니다. 외부 페이지 컨테이너에 overflow-hidden을 추가하여 확대된 배경이 클리핑되도록 조정했으며, 기존의 고정 높이 배경 요소(h-[320px])는 제거했습니다. Google 로그인 처리 및 에러 렌더링 로직은 변경되지 않았습니다.

Possibly related PRs

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed PR 제목이 주요 변경사항을 명확하게 요약하고 있습니다. 랜딩페이지 배경 여백 제거라는 구체적인 목표를 간결하게 표현했습니다.
Description check ✅ Passed PR 설명이 템플릿 구조를 따르고 있으며, 관련 이슈(#442)를 명시하고 변경 사항을 명확하게 설명했습니다.
Linked Issues check ✅ Passed 이슈 #442의 목표인 로그인페이지 배경 크기 조정이 SVG 변경을 통해 달성되었습니다. 기존 배경을 새로운 전체 배경 이미지로 교체하여 화면에 맞게 조정했습니다.
Out of Scope Changes check ✅ Passed 코드 변경사항이 모두 랜딩페이지 배경 교체에 관련되어 있으며, 이슈 #442의 범위 내에서 이루어졌습니다.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/#442-resize-loginpage-background

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/app/LandingPage.tsx`:
- Line 32: Type error occurs because svgr.d.ts declares SVGs as strings while
next.config.ts produces React components; update svgr.d.ts to declare default
export as a React functional component (e.g., React.FunctionComponent with SVG
props and optional title) so components like SofaLoginBackgroundFull can be used
with props such as preserveAspectRatio and aria-hidden; keep the current usage
in LandingPage.tsx and remove the temporary wrapper/remove-prop workarounds once
the declaration is updated.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 37a89154-e3ea-4ae0-9024-b5da3f8dd98d

📥 Commits

Reviewing files that changed from the base of the PR and between 69b8de2 and 1e09f07.

⛔ Files ignored due to path filters (2)
  • src/components/Icons/svgs/ic_landing_background.svg is excluded by !**/*.svg
  • src/components/Icons/svgs/sofa_login_bg_full.svg is excluded by !**/*.svg
📒 Files selected for processing (1)
  • src/app/LandingPage.tsx

Comment thread src/app/LandingPage.tsx Outdated
@Seong-Myeong Seong-Myeong merged commit c9741da into main Mar 31, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

로그인페이지 배경 크기 조정

2 participants