Open
Conversation
refactor: Azure 의존성 제거 및 Docker 빌드 경로 수정
There was a problem hiding this comment.
Code Review
This pull request transitions the application from Azure Key Vault-based connection string management to standard configuration strings. It removes Azure-related dependencies and initialization code from the project file and Program.cs, updates the appsettings files, and refactors the database configuration logic. A review comment suggests changing the new English exception message in DatabaseConfig.cs to Korean to maintain consistency with the existing codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚작업 내용
ConnectionStrings:Default) 기반으로 전환IsNullOrWhiteSpace적용)PushAndPull/Server→PushAndPull/PushAndPull)DB_CONNECTION_STRING시크릿 단일 환경변수로 교체csproj파일 BOM 제거기존에는 Azure Key Vault를 통해 DB 연결 문자열을 가져왔으나, 학교 서버(일반 VPS) 환경에서 Azure 서비스 의존성이 불필요하여 제거했습니다.
변경 전: Azure Key Vault + 서비스 프린시펄 자격증명(AZURE_CLIENT_ID/SECRET/TENANT_ID)을 Docker 환경변수로 주입
변경 후: GitHub Secret
DB_CONNECTION_STRING을 Docker 환경변수ConnectionStrings__Default로 직접 주입✅체크리스트