Open
Conversation
added 4 commits
October 27, 2018 01:15
… catches for teleporting within the same dimension
Owner
|
I am a bit confused, is this a different PR from #1 ? Should I close the other one? |
Author
|
I was unable to figure out how to update the first pull request, I don't
think that is the intent.
You should reject the first PR as it actually did not work for multiplayer.
The one I did now is the newest version.
…On Tue, 30 Apr 2019 at 23:22, Zander ***@***.***> wrote:
I am a bit confused, is this a different PR from #1
<#1> ? Should I close the other
one?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAMIHOAX6PZBGAH4VKP7R23PTEZJ3ANCNFSM4HJR4NEA>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've got some buddies on my test server and we've done a couple iterations of tests that have all returned successfully.