chore: enforce pnpm 11#10749
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughRoot ChangesMinimum pnpm version requirement
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
View your CI Pipeline Execution ↗ for commit bb0ead4
☁️ Nx Cloud last updated this comment at |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Around line 8-11: The package.json has a mismatch between packageManager
("packageManager") set to "pnpm@10.24.0" and the engines constraint
("engines.pnpm") requiring ">=11.0.0"; update the packageManager entry to a pnpm
11.x pin (for example "pnpm@11.0.0" or an appropriate 11.x version) so both
packageManager and engines.pnpm align, or alternatively relax engines.pnpm to
allow 10.24.0—change the packageManager field to match the engines.pnpm
requirement to resolve the contradiction.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
Collaborator
|
hmm setup tools fails: |
Contributor
Author
Ah yeah sorry I thought this one had been merged #10699 |
Collaborator
merged it now |
TkDodo
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
engines.pnpm >=11.0.0to TanStack/query.pnpm@11+ installpnpm@11+ run ...pnpm@9 installengines.pnpmpnpm@9 run ...engines.pnpmpnpm@10 installwith default pnpm version managementpackageManagerand runs as the declared pnpm versionpnpm@10 run ...with default pnpm version managementpackageManagerand runs as the declared pnpm versionpnpm@10 installwith version handoff disabledengines.pnpmpnpm@10 run ...with version handoff disabledengines.pnpmpnpm@9/10 listpnpm@9/10 exec ...packageManagerengines.pnpm: \">=11.0.0\"engines.pnpmSummary by CodeRabbit