feat(eslint-plugin-query): add ESLint v10 to peer dependencies#10182
feat(eslint-plugin-query): add ESLint v10 to peer dependencies#10182lbo728 wants to merge 2 commits intoTanStack:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 8d90510 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: defaults Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds a changeset and updates the eslint-plugin-query package to declare compatibility with ESLint v10 and bumps Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/eslint-plugin-query/package.json (1)
62-62:⚠️ Potential issue | 🟠 MajorBump
@typescript-eslint/utilsminimum to^8.56.0to match declared ESLint v10 supportThis package declares ESLint v10 compatibility in peerDependencies (
"eslint": "^8.57.0 || ^9.0.0 || ^10.0.0"), but@typescript-eslint/utilsv8.48.0–v8.55.x do not support ESLint v10 in their own peerDependencies (they cap at"eslint": "^8.57.0 || ^9.0.0"). Only v8.56.0 introduced ESLint v10 support. A consumer with a deduplicated lockfile using an older patch version while installing ESLint v10 will encounter a peerDependency conflict despite the package claiming compatibility.Proposed fix
- "@typescript-eslint/utils": "^8.48.0" + "@typescript-eslint/utils": "^8.56.0"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/eslint-plugin-query/package.json` at line 62, The package.json currently pins "@typescript-eslint/utils": "^8.48.0", which allows installing versions that lack ESLint v10 peer support; update the dependency to "@typescript-eslint/utils": "^8.56.0" (or higher) in package.json to ensure ESLint v10 is supported, then regenerate the lockfile (npm/yarn/pnpm install) and run the test/lint pipeline to validate no new peer conflicts.
🧹 Nitpick comments (1)
packages/eslint-plugin-query/package.json (1)
64-69: BumpdevDependencies.eslintto cover ESLint v10 so the declared peerDependency is actually testedThe dev/test environment still pins
eslintto^9.36.0. ESLint v10.0.0 was released on 06 Feb 2026 as a major release that includes several breaking changes. Running the test suite only against ESLint v9 means the newly declared^10.0.0peer compatibility is untested. Consider updating thedevDependenciesto^10.0.0(or adding a matrix CI job that also runs against ESLint v10).📦 Proposed fix
- "eslint": "^9.36.0", + "eslint": "^10.0.0",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/eslint-plugin-query/package.json` around lines 64 - 69, Update the dev/test environment to actually test ESLint v10 by changing the "eslint" entry under devDependencies in package.json from "^9.36.0" to "^10.0.0" (i.e., bump devDependencies.eslint) and run the test suite to confirm compatibility; alternatively, add a CI matrix job that runs tests against both "^9.x" and "^10.x" to ensure the declared peerDependency is covered.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@packages/eslint-plugin-query/package.json`:
- Line 62: The package.json currently pins "@typescript-eslint/utils":
"^8.48.0", which allows installing versions that lack ESLint v10 peer support;
update the dependency to "@typescript-eslint/utils": "^8.56.0" (or higher) in
package.json to ensure ESLint v10 is supported, then regenerate the lockfile
(npm/yarn/pnpm install) and run the test/lint pipeline to validate no new peer
conflicts.
---
Nitpick comments:
In `@packages/eslint-plugin-query/package.json`:
- Around line 64-69: Update the dev/test environment to actually test ESLint v10
by changing the "eslint" entry under devDependencies in package.json from
"^9.36.0" to "^10.0.0" (i.e., bump devDependencies.eslint) and run the test
suite to confirm compatibility; alternatively, add a CI matrix job that runs
tests against both "^9.x" and "^10.x" to ensure the declared peerDependency is
covered.
1 participant
🎯 Changes
ESLint v10 was released in February 2026. This PR adds ESLint v10 to the
peerDependenciesof@tanstack/eslint-plugin-queryto officially declare compatibility.The plugin's core dependency
@typescript-eslint/utilsalready supports ESLint v10 (^8.57.0 || ^9.0.0 || ^10.0.0), so no source code changes are required — only the peer dependency range needs to be updated.Closes #10141
✅ Checklist
pnpm run test:pr.🚀 Release Impact
Summary by CodeRabbit