Organize build structure and refactor code#1
Open
MoriokaReimen wants to merge 4 commits intoTai-Min:masterfrom
Open
Organize build structure and refactor code#1MoriokaReimen wants to merge 4 commits intoTai-Min:masterfrom
MoriokaReimen wants to merge 4 commits intoTai-Min:masterfrom
Conversation
Owner
|
Hello! Sorry for REALLY late response but I'm a bit busy with my master's thesis and the semester overall. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Mr. Tai-Min
Your Boost-Serial-Port project got my attention and I found that this project is the best Serial communication library for my hobby arduino project. I am sure this project helps a number of hobby developers like me.
I found some room for improving this library. Therefore, I decided to make this pull request.
Through this pull request, I did some code-refactor as below.
astyle -A8code formatterENABLE_TESTCMake option is enabled.I hope this pull request helps you.
Thank you.