Open
Conversation
jakubzitny
requested changes
Jan 4, 2022
Collaborator
jakubzitny
left a comment
jakubzitny
left a comment
There was a problem hiding this comment.
Seems okay, leaving few nits.
| and control over pausing / resuming the upload. | ||
|
|
||
| ## This branch allows to use Custom port for S3 endpoint | ||
|
|
Collaborator
There was a problem hiding this comment.
Can we get rid of this comment? If merged, it seems unnecessary
|
|
||
| if (!!port && 80 != port && 443 != port) { | ||
| this.awsHost += (':' + port ); | ||
| } |
Collaborator
There was a problem hiding this comment.
If you could align the tabs/padding that would be great.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some time S3 clones (like minio) is running on custom ports. This fix allows us to specify the port in AWS URL