Fix block overlay was seen through the Interfaces block preview#429
Merged
Fix block overlay was seen through the Interfaces block preview#429
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a rendering issue where the vanilla block-selection overlay could appear “through” the Interface block preview by adjusting GL state handling during the highlight render.
Changes:
- Wrap highlight rendering in
GlStateTracker.pushState()/popState()to avoid leaking GL state. - Stop using
depthMask(false)during the item-preview render so the preview writes to the depth buffer. - Refactor overlay box rendering to use
CRenderUtils.renderCube(...)and centralize translucent/xray state setup.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ブロックの選択オーバーレイが、粘土インターフェース系ブロックのプレビューを貫通していたのを修正。