Conversation
talister
approved these changes
Apr 3, 2026
Collaborator
talister
left a comment
talister
left a comment
There was a problem hiding this comment.
This looks good to me and I've tested it out with the runserver and pre-inserted early versions of a specific (real) Scout object, which then updated properly to the real values. (There's not much genuine updating of Scout right now because Full Moon)
One note before the "V1.0" of tom_jpl: I should be put into the pyproject.toml under the authors and replacing Rachel in the maintainers
phycodurus
approved these changes
Apr 6, 2026
…-be-updated-each-time-it-is-saved-if-not-created
Coverage Report for PR #5Coverage decreased (-0.04%) to 85.423%Diff Coverage: 20 of 21 changed lines covered (95.24%)Uncovered Changes
Coverage Regressions1 previously-covered line in 1 file lost coverage.
💛 - Coveralls |
jchate6
deleted the
3-scout-targets-should-be-updated-each-time-it-is-saved-if-not-created
branch
github-project-automation
bot
moved this from Needs Review
to Merged (to dev)
in TOM Toolkit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This automatically updates both the orbital elements and the scout data each time a target is created via the SCOUT dataservice